Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 399643002: DevTools: Support multiple target in ScriptFormatterAction (Closed)

Created:
6 years, 5 months ago by sergeyv
Modified:
6 years, 5 months ago
Reviewers:
vsevik
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: Support multiple target in ScriptFormatterAction BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178441

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address vsevik's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+199 lines, -162 lines) Patch
M Source/devtools/front_end/sources/ScriptFormatterEditorAction.js View 1 7 chunks +199 lines, -162 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
sergeyv
6 years, 5 months ago (2014-07-16 13:52:26 UTC) #1
vsevik
https://chromiumcodereview.appspot.com/399643002/diff/1/Source/devtools/front_end/sources/ScriptFormatterEditorAction.js File Source/devtools/front_end/sources/ScriptFormatterEditorAction.js (right): https://chromiumcodereview.appspot.com/399643002/diff/1/Source/devtools/front_end/sources/ScriptFormatterEditorAction.js#newcode351 Source/devtools/front_end/sources/ScriptFormatterEditorAction.js:351: var debuggerModels = WebInspector.targetManager.targets().select("debuggerModel"); Please, no
6 years, 5 months ago (2014-07-18 08:48:46 UTC) #2
vsevik
lgtm
6 years, 5 months ago (2014-07-18 09:02:41 UTC) #3
sergeyv
https://codereview.chromium.org/399643002/diff/1/Source/devtools/front_end/sources/ScriptFormatterEditorAction.js File Source/devtools/front_end/sources/ScriptFormatterEditorAction.js (right): https://codereview.chromium.org/399643002/diff/1/Source/devtools/front_end/sources/ScriptFormatterEditorAction.js#newcode351 Source/devtools/front_end/sources/ScriptFormatterEditorAction.js:351: var debuggerModels = WebInspector.targetManager.targets().select("debuggerModel"); On 2014/07/18 08:48:46, vsevik wrote: ...
6 years, 5 months ago (2014-07-18 11:46:01 UTC) #4
sergeyv
The CQ bit was checked by sergeyv@chromium.org
6 years, 5 months ago (2014-07-18 11:46:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyv@chromium.org/399643002/20001
6 years, 5 months ago (2014-07-18 11:46:54 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-07-18 12:47:08 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-18 13:48:04 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/17723)
6 years, 5 months ago (2014-07-18 13:48:04 UTC) #9
sergeyv
The CQ bit was checked by sergeyv@chromium.org
6 years, 5 months ago (2014-07-18 13:56:06 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyv@chromium.org/399643002/20001
6 years, 5 months ago (2014-07-18 13:56:24 UTC) #11
commit-bot: I haz the power
6 years, 5 months ago (2014-07-18 14:27:43 UTC) #12
Message was sent while issue was closed. 
Change committed as 178441

Powered by Google App Engine
This is Rietveld 408576698