Issue 399623005: Revert 283490 "Add GN build targets for the rest of mojo/public"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 399623005: Revert 283490 "Add GN build targets for the rest of mojo/public" (Closed)

Created:
6 years, 5 months ago by Pete Williamson

Modified:
6 years, 5 months ago

Reviewers:
Chris Masone

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 283490 "Add GN build targets for the rest of mojo/public" This appears to cause a compile faliure on buildbots. > Add GN build targets for the rest of mojo/public > > BUG=369643 > TEST='gn gen out/Debug && ninja -C out/Debug mojo > > Review URL: https://codereview.chromium.org/388333003 TBR=cmasone@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283497

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -177 lines)			Patch
M	trunk/src/mojo/BUILD.gn	View	1 chunk	+4 lines, -7 lines	0 comments	Download
D	trunk/src/mojo/bindings/java/BUILD.gn	View	1 chunk	+0 lines, -24 lines	0 comments	Download
M	trunk/src/mojo/mojo_public.gypi	View	6 chunks	+0 lines, -6 lines	0 comments	Download
D	trunk/src/mojo/public/BUILD.gn	View	1 chunk	+0 lines, -22 lines	0 comments	Download
D	trunk/src/mojo/public/c/system/BUILD.gn	View	1 chunk	+0 lines, -28 lines	0 comments	Download
D	trunk/src/mojo/public/cpp/application/BUILD.gn	View	1 chunk	+0 lines, -22 lines	0 comments	Download
D	trunk/src/mojo/public/cpp/environment/BUILD.gn	View	1 chunk	+0 lines, -18 lines	0 comments	Download
D	trunk/src/mojo/public/cpp/utility/BUILD.gn	View	1 chunk	+0 lines, -28 lines	0 comments	Download
D	trunk/src/mojo/public/java/BUILD.gn	View	1 chunk	+0 lines, -22 lines	0 comments	Download

Total messages: 2 (0 generated)

Pete Williamson

6 years, 5 months ago (2014-07-16 20:57:24 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r283497 (tree was closed).