Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 399613008: Caret is showing after do a Cut operation from editable field. (Closed)

Created:
6 years, 5 months ago by Cyan
Modified:
6 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, AKVT, AviD, ankit
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Hide the insertion handle when performing a Cut Make behavior uniform with other apps on Android, where after a Cut from an editable field, the insertion handle is hidden and only the cursor remains visible. https://codereview.chromium.org/394953005/ BUG:394781 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284138

Patch Set 1 #

Patch Set 2 : Adding names in AUTHORS file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M AUTHORS View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/SelectActionModeCallback.java View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 22 (0 generated)
Cyan
@jdduke PTAL
6 years, 5 months ago (2014-07-17 10:20:17 UTC) #1
Cyan
6 years, 5 months ago (2014-07-17 10:26:32 UTC) #2
jdduke (slow)
I think aurimas@ may have added this code original (though that was probably just from ...
6 years, 5 months ago (2014-07-17 14:53:21 UTC) #3
Cyan
On 2014/07/17 14:53:21, jdduke wrote: > I think aurimas@ may have added this code original ...
6 years, 5 months ago (2014-07-17 15:16:24 UTC) #4
aurimas (slooooooooow)
lgtm
6 years, 5 months ago (2014-07-17 16:14:58 UTC) #5
Cyan
The CQ bit was checked by sayan.nayak@samsung.com
6 years, 5 months ago (2014-07-18 05:11:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sayan.nayak@samsung.com/399613008/1
6 years, 5 months ago (2014-07-18 05:13:24 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-18 07:36:01 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-18 07:39:15 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/80822)
6 years, 5 months ago (2014-07-18 07:39:15 UTC) #10
Cyan
On 2014/07/18 07:39:15, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 5 months ago (2014-07-18 09:16:00 UTC) #11
jdduke (slow)
On 2014/07/18 09:16:00, sayan.nayak wrote: > On 2014/07/18 07:39:15, I haz the power (commit-bot) wrote: ...
6 years, 5 months ago (2014-07-18 12:47:00 UTC) #12
Cyan
The CQ bit was checked by sayan.nayak@samsung.com
6 years, 5 months ago (2014-07-18 12:48:29 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sayan.nayak@samsung.com/399613008/1
6 years, 5 months ago (2014-07-18 12:49:07 UTC) #14
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 5 months ago (2014-07-18 12:51:58 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-18 12:57:55 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/80869)
6 years, 5 months ago (2014-07-18 12:57:56 UTC) #17
Cyan
@jdduke added my name in AUTHORS file and uploaded new patchset. PTAL
6 years, 5 months ago (2014-07-18 13:18:06 UTC) #18
jdduke (slow)
On 2014/07/18 13:18:06, sayan.nayak wrote: > @jdduke > added my name in AUTHORS file and ...
6 years, 5 months ago (2014-07-18 14:55:29 UTC) #19
Cyan
The CQ bit was checked by sayan.nayak@samsung.com
6 years, 5 months ago (2014-07-18 15:02:24 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sayan.nayak@samsung.com/399613008/20001
6 years, 5 months ago (2014-07-18 15:03:14 UTC) #21
commit-bot: I haz the power
6 years, 5 months ago (2014-07-18 17:33:34 UTC) #22
Message was sent while issue was closed.
Change committed as 284138

Powered by Google App Engine
This is Rietveld 408576698