|
|
DescriptionHide the insertion handle when performing a Cut
Make behavior uniform with other apps on Android,
where after a Cut from an editable field, the
insertion handle is hidden and only the cursor
remains visible.
https://codereview.chromium.org/394953005/
BUG:394781
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284138
Patch Set 1 #Patch Set 2 : Adding names in AUTHORS file #Messages
Total messages: 22 (0 generated)
@jdduke PTAL
I think aurimas@ may have added this code original (though that was probably just from upstreaming?), so I'll defer review to him. In any case, this looks good and may have simply been an oversight to make the call in the original implementation? Could you also update the title/description according to the comments I left at https://codereview.chromium.org/394953005/? Note that when you go to "Edit Issue", the first line in the "Description" field will be used as the submitted patch title, and the remaining text is used in the patch description. Thanks.
On 2014/07/17 14:53:21, jdduke wrote: > I think aurimas@ may have added this code original (though that was probably > just from upstreaming?), so I'll defer review to him. In any case, this looks > good and may have simply been an oversight to make the call in the original > implementation? > > Could you also update the title/description according to the comments I left at > https://codereview.chromium.org/394953005/ Note that when you go to "Edit > Issue", the first line in the "Description" field will be used as the submitted > patch title, and the remaining text is used in the patch description. Thanks. @aurimas: PTAL
lgtm
The CQ bit was checked by sayan.nayak@samsung.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sayan.nayak@samsung.com/399613008/1
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...) chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
On 2014/07/18 07:39:15, I haz the power (commit-bot) wrote: > Try jobs failed on following builders: > chromium_presubmit on tryserver.chromium > (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...) @jdduke,aurimas: I'm getting this error during commit. ** Presubmit ERRORS ** Missing LGTM from an OWNER for these files: content/public/android/java/src/org/chromium/content/browser/SelectActionModeCallback.java
On 2014/07/18 09:16:00, sayan.nayak wrote: > On 2014/07/18 07:39:15, I haz the power (commit-bot) wrote: > > Try jobs failed on following builders: > > chromium_presubmit on tryserver.chromium > > > (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...) > > @jdduke,aurimas: > I'm getting this error during commit. > ** Presubmit ERRORS ** > Missing LGTM from an OWNER for these files: > > content/public/android/java/src/org/chromium/content/browser/SelectActionModeCallback.java lgtm
The CQ bit was checked by sayan.nayak@samsung.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sayan.nayak@samsung.com/399613008/1
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
@jdduke added my name in AUTHORS file and uploaded new patchset. PTAL
On 2014/07/18 13:18:06, sayan.nayak wrote: > @jdduke > added my name in AUTHORS file and uploaded new patchset. > PTAL lgtm, thanks.
The CQ bit was checked by sayan.nayak@samsung.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sayan.nayak@samsung.com/399613008/20001
Message was sent while issue was closed.
Change committed as 284138 |