Issue 399613003: SignAndStore method is moved out from DeviceSettingsService to OwnerSettingsService. It's still cal…

Issue 399613003: SignAndStore method is moved out from DeviceSettingsService to OwnerSettingsService. It's still cal… (Closed)

Created:
6 years, 5 months ago by ygorshenin1

Modified:
6 years, 5 months ago

Reviewers:
pastarmovj

CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

SignAndStore method is moved out from DeviceSettingsService to OwnerSettingsService. It's still called by DeviceSettingsService via delegate, but later it will be invoked by OwnerSettingsService::Set(). BUG=230018 TEST=unit_tests:DeviceSettingsService* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284081

Patch Set 1 #

Patch Set 2 : Deleted inclusion of dbus_thread_manager.h. #

Total comments: 2

Patch Set 3 : Fix. #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+294 lines, -133 lines)			Patch
A +	chrome/browser/chromeos/ownership/OWNERS	View	1 2	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/browser/chromeos/ownership/owner_settings_service.h	View		6 chunks	+39 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/ownership/owner_settings_service.cc	View	1	8 chunks	+207 lines, -20 lines	0 comments	Download
M	chrome/browser/chromeos/settings/device_settings_service.h	View	1 2	8 chunks	+37 lines, -20 lines	0 comments	Download
M	chrome/browser/chromeos/settings/device_settings_service.cc	View		4 chunks	+12 lines, -93 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

pastarmovj

Sorry for the delay! lgtm with a nit. https://codereview.chromium.org/399613003/diff/40001/chrome/browser/chromeos/settings/device_settings_service.h File chrome/browser/chromeos/settings/device_settings_service.h (right): https://codereview.chromium.org/399613003/diff/40001/chrome/browser/chromeos/settings/device_settings_service.h#newcode178 chrome/browser/chromeos/settings/device_settings_service.h:178: void ...

6 years, 5 months ago (2014-07-18 11:20:16 UTC) #3

ygorshenin1

Many thanks! https://codereview.chromium.org/399613003/diff/40001/chrome/browser/chromeos/settings/device_settings_service.h File chrome/browser/chromeos/settings/device_settings_service.h (right): https://codereview.chromium.org/399613003/diff/40001/chrome/browser/chromeos/settings/device_settings_service.h#newcode178 chrome/browser/chromeos/settings/device_settings_service.h:178: void SetManagementSettings( On 2014/07/18 11:20:16, pastarmovj wrote: ...

6 years, 5 months ago (2014-07-18 11:48:47 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ygorshenin@chromium.org/399613003/60001

6 years, 5 months ago (2014-07-18 11:50:16 UTC) #6

Message was sent while issue was closed.

Change committed as 284081

Expand Messages | Collapse Messages