ui/login/account_picker/screen_account_picker.js - Issue 399613002: Anti-shelf-overlapping fixes for several menus.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/login/account_picker/screen_account_picker.js

Issue 399613002: Anti-shelf-overlapping fixes for several menus. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Helper function extracted. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/login/account_picker/screen_account_picker.js

diff --git a/ui/login/account_picker/screen_account_picker.js b/ui/login/account_picker/screen_account_picker.js

index 3d14d363ccefe5c64b1e5238adc9a21fce7c8b77..3d216fa942b0ddc22a5dce635c6c9351f8b9537a 100644

--- a/ui/login/account_picker/screen_account_picker.js

+++ b/ui/login/account_picker/screen_account_picker.js

@@ -162,6 +162,15 @@ login.createScreen('AccountPickerScreen', 'account-picker', function() {

cr.ui.Bubble.Attachment.BOTTOM,

error,

BUBBLE_OFFSET, BUBBLE_PADDING);

+ // Move error bubble up if it overlaps the shelf.

+ var maxHeight =

+ cr.ui.LoginUiTools.getMaxHeightBeforeShelfOverlapping($('bubble'));

+ if (maxHeight < $('bubble').offsetHeight) {

+ $('bubble').showContentForElement(activatedPod.mainInput,

+ cr.ui.Bubble.Attachment.TOP,

+ error,

+ BUBBLE_OFFSET, BUBBLE_PADDING);

+ }

}