Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2613)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/resources/chromeos/login/oobe.js

Issue 399613002: Anti-shelf-overlapping fixes for several menus. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/chromeos/login/network_dropdown.js ('k') | ui/login/account_picker/screen_account_picker.js » ('j') | ui/login/account_picker/user_pod_row.css » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/chromeos/login/oobe.js
diff --git a/chrome/browser/resources/chromeos/login/oobe.js b/chrome/browser/resources/chromeos/login/oobe.js
index f198d55cea21128495b28b76283f84f6838ab78d..455c228a1a345dd8714cad178e75c0c8aeeac0b2 100644
--- a/chrome/browser/resources/chromeos/login/oobe.js
+++ b/chrome/browser/resources/chromeos/login/oobe.js
@@ -146,6 +146,15 @@ cr.define('cr.ui.Oobe', function() {
$('accessibility-menu').showForElement(e.target,
cr.ui.Bubble.Attachment.BOTTOM,
BUBBLE_OFFSET, BUBBLE_PADDING);
+
+ var maxHeight = Oobe.getMaxHeightBeforeShelfOverlapping(
+ $('accessibility-menu'));
+ if (maxHeight < $('accessibility-menu').offsetHeight) {
+ $('accessibility-menu').showForElement(e.target,
+ cr.ui.Bubble.Attachment.TOP,
+ BUBBLE_OFFSET, BUBBLE_PADDING);
+ }
+
$('accessibility-menu').firstBubbleElement = $('spoken-feedback');
$('accessibility-menu').lastBubbleElement = $('close-accessibility-menu');
if (Oobe.getInstance().currentScreen &&
« no previous file with comments | « chrome/browser/resources/chromeos/login/network_dropdown.js ('k') | ui/login/account_picker/screen_account_picker.js » ('j') | ui/login/account_picker/user_pod_row.css » ('J')

Powered by Google App Engine
This is Rietveld 408576698