Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Side by Side Diff: ui/login/login_ui_tools.js

Issue 399613002: Anti-shelf-overlapping fixes for several menus. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Helper function extracted. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « ui/login/account_picker/user_pod_row.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 /**
6 * @fileoverview JS helpers used on login.
7 */
8
9 cr.define('cr.ui', function() {
10
11 function LoginUiTools() {
dzhioev (left Google) 2014/08/01 16:26:13 LoginUITools shouldn't be a function, object will
dzhioev (left Google) 2014/08/01 16:26:13 nit: 'Ui' looks ugly. I prefer LoginUITools
merkulova 2014/08/04 06:39:29 Done.
merkulova 2014/08/04 06:39:29 Done.
12 }
13
14 /**
15 * Computes max-height for an element so that it doesn't overlap shelf.
16 * @param {element} DOM element
17 */
18 LoginUiTools.getMaxHeightBeforeShelfOverlapping = function(element) {
19 var maxAllowedHeight =
20 $('outer-container').offsetHeight -
21 element.getBoundingClientRect().top -
22 parseInt(window.getComputedStyle(element).marginTop) -
23 parseInt(window.getComputedStyle(element).marginBottom);
24 return maxAllowedHeight;
25 };
26
27 // Export
28 return {
29 LoginUiTools: LoginUiTools
30 };
31 });
OLDNEW
« no previous file with comments | « ui/login/account_picker/user_pod_row.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698