Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 399603002: Replace usage of NOTIFICATION_EXTENSION_UNLOADED with ExtensionRegistryObserver. (Closed)

Created:
6 years, 5 months ago by Bernhard Bauer
Modified:
6 years, 5 months ago
Reviewers:
falken
CC:
chromium-reviews, dbeam+watch-options_chromium.org
Visibility:
Public.

Description

Replace usage of NOTIFICATION_EXTENSION_UNLOADED with ExtensionRegistryObserver. This also fixes a bug caused by registering for notifications in all profiles instead of just our own. BUG=394158, 354046 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283831

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -21 lines) Patch
M chrome/browser/ui/webui/options/font_settings_handler.h View 4 chunks +16 lines, -9 lines 0 comments Download
M chrome/browser/ui/webui/options/font_settings_handler.cc View 5 chunks +15 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Bernhard Bauer
Please review.
6 years, 5 months ago (2014-07-17 14:09:04 UTC) #1
falken
lgtm
6 years, 5 months ago (2014-07-17 16:21:27 UTC) #2
Bernhard Bauer
The CQ bit was checked by bauerb@chromium.org
6 years, 5 months ago (2014-07-17 16:32:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/399603002/1
6 years, 5 months ago (2014-07-17 16:34:13 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 19:09:00 UTC) #5
Message was sent while issue was closed.
Change committed as 283831

Powered by Google App Engine
This is Rietveld 408576698