Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 399593003: One more round of extensions code ifdefing in profiles code. (Closed)

Created:
6 years, 5 months ago by Lei Zhang
Modified:
6 years, 5 months ago
Reviewers:
noms (inactive)
CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, zea+watch_chromium.org, maniscalco+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

One more round of extensions code ifdefing in profiles code. BUG=349436 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285686

Patch Set 1 : #

Patch Set 2 : rebase #

Patch Set 3 : fix typo #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -33 lines) Patch
M chrome/browser/profiles/profile_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 1 2 3 12 chunks +36 lines, -15 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.h View 1 2 3 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.cc View 1 2 3 10 chunks +22 lines, -5 lines 0 comments Download
M chrome/browser/sync/profile_sync_components_factory_impl.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/sync/profile_sync_components_factory_impl.cc View 1 4 chunks +6 lines, -9 lines 0 comments Download

Messages

Total messages: 21 (0 generated)
Lei Zhang
6 years, 5 months ago (2014-07-18 23:43:30 UTC) #1
noms (inactive)
lgtm
6 years, 5 months ago (2014-07-21 13:52:30 UTC) #2
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 5 months ago (2014-07-21 18:56:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/399593003/40001
6 years, 5 months ago (2014-07-21 18:58:13 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-21 23:00:50 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-22 00:11:21 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/173237)
6 years, 5 months ago (2014-07-22 00:11:21 UTC) #7
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 5 months ago (2014-07-24 04:38:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/399593003/60001
6 years, 5 months ago (2014-07-24 04:41:44 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-24 07:58:50 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-24 09:09:49 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/174245)
6 years, 5 months ago (2014-07-24 09:09:50 UTC) #12
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 5 months ago (2014-07-24 22:03:14 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/399593003/80001
6 years, 5 months ago (2014-07-24 22:04:53 UTC) #14
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-25 01:39:03 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-25 03:30:27 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/builds/34472)
6 years, 5 months ago (2014-07-25 03:30:28 UTC) #17
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 5 months ago (2014-07-25 19:21:53 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/399593003/100001
6 years, 5 months ago (2014-07-25 19:23:03 UTC) #19
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_clang_dbg on tryserver.chromium ...
6 years, 5 months ago (2014-07-25 21:11:37 UTC) #20
commit-bot: I haz the power
6 years, 5 months ago (2014-07-25 21:33:25 UTC) #21
Message was sent while issue was closed. 
Change committed as 285686

Powered by Google App Engine
This is Rietveld 408576698