components/password_manager/core/browser/password_manager_metrics_util.h - Issue 399573002: [Password Generation] Trigger confirmation bubble when a password is saved

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_manager_metrics_util.h

Issue 399573002: [Password Generation] Trigger confirmation bubble when a password is saved (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Comments Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/passwords/manage_passwords_icon_view.cc ('K') | « components/password_manager/core/browser/password_manager_client.h ('k') | components/password_manager/core/browser/password_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_manager_metrics_util.h

diff --git a/components/password_manager/core/browser/password_manager_metrics_util.h b/components/password_manager/core/browser/password_manager_metrics_util.h

index e74b97a8b472b6e2b503d179b391160cd92a90e3..779d77d09db847bd5b35f13b5eb25a9b222bc605 100644

--- a/components/password_manager/core/browser/password_manager_metrics_util.h

+++ b/components/password_manager/core/browser/password_manager_metrics_util.h

@@ -28,6 +28,7 @@ enum UIDisplayDisposition {

MANUAL_WITH_PASSWORD_PENDING,

MANUAL_MANAGE_PASSWORDS,

MANUAL_BLACKLISTED,

+ AUTOMATIC_GENERATED_PASSWORD_CONFIRMATION,

NUM_DISPLAY_DISPOSITIONS

};

@@ -42,6 +43,7 @@ enum UIDismissalReason {

CLICKED_MANAGE,

CLICKED_DONE,

CLICKED_UNBLACKLIST,

+ CLICKED_OK,

NUM_UI_RESPONSES,

// If we add the omnibox icon _without_ intending to display the bubble,