Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1528)

Unified Diff: chrome/browser/ui/views/passwords/manage_passwords_view_test.cc

Issue 399573002: [Password Generation] Trigger confirmation bubble when a password is saved (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Comments Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/passwords/manage_passwords_view_test.cc
diff --git a/chrome/browser/ui/views/passwords/manage_passwords_view_test.cc b/chrome/browser/ui/views/passwords/manage_passwords_view_test.cc
index b1f8f44969adb30cf9ac57f8c97748d582858a58..da4401e7c871f09288fa3769810bf44cbbbbd33f 100644
--- a/chrome/browser/ui/views/passwords/manage_passwords_view_test.cc
+++ b/chrome/browser/ui/views/passwords/manage_passwords_view_test.cc
@@ -70,7 +70,21 @@ void ManagePasswordsViewTest::SetupPendingPassword() {
scoped_ptr<password_manager::PasswordFormManager> test_form_manager(
new password_manager::PasswordFormManager(
NULL, &client, &driver, *test_form(), false));
- controller()->OnPasswordSubmitted(test_form_manager.release());
+ controller()->OnPasswordSubmitted(test_form_manager.Pass());
+
+ // Wait for the command execution triggered by the automatic popup to pop up
+ // the bubble.
+ content::RunAllPendingInMessageLoop();
+ controller()->UpdateIconAndBubbleState(view());
+}
+
+void ManagePasswordsViewTest::SetupAutomaticPassword() {
+ password_manager::StubPasswordManagerClient client;
+ password_manager::StubPasswordManagerDriver driver;
+ scoped_ptr<password_manager::PasswordFormManager> test_form_manager(
+ new password_manager::PasswordFormManager(
+ NULL, &client, &driver, *test_form(), false));
+ controller()->OnAutomaticPasswordSave(test_form_manager.Pass());
// Wait for the command execution triggered by the automatic popup to pop up
// the bubble.

Powered by Google App Engine
This is Rietveld 408576698