Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Unified Diff: components/password_manager/core/common/password_manager_ui.h

Issue 399573002: [Password Generation] Trigger confirmation bubble when a password is saved (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Win Again Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/common/password_manager_ui.h
diff --git a/components/password_manager/core/common/password_manager_ui.h b/components/password_manager/core/common/password_manager_ui.h
index 9f28a40be373c89e601318aa20a05d6e65c97a00..2728c61dd9816851e8b829d8478dee2a94da3847 100644
--- a/components/password_manager/core/common/password_manager_ui.h
+++ b/components/password_manager/core/common/password_manager_ui.h
@@ -24,6 +24,10 @@ enum State {
// A password is pending, but we don't need to pop up a bubble.
PENDING_PASSWORD_STATE,
+ // A password has been saved and we wish to display UI confirming the save
+ // to the user.
+ CONFIRMATION_STATE,
+
// A password has been autofilled, or has just been saved. The icon needs
// to be visible, in the management state.
MANAGE_STATE,
@@ -36,6 +40,14 @@ enum State {
// Returns true if |state| represents a pending password.
bool IsPendingState(State state);
+// Returns true if this state show cause the bubble to be shown without user
+// interaction.
+bool IsAutomaticDisplayState(State state);
+
+// Returns the state that the bubble should be in after the automatic display
+// occurs.
+State GetEndStateForAutomaticState(State state);
+
} // namespace ui
} // namespace password_manager

Powered by Google App Engine
This is Rietveld 408576698