chrome/browser/password_manager/save_password_infobar_delegate.cc - Issue 399573002: [Password Generation] Trigger confirmation bubble when a password is saved

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/save_password_infobar_delegate.cc

Issue 399573002: [Password Generation] Trigger confirmation bubble when a password is saved (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Win Again Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/save_password_infobar_delegate.h ('k') | chrome/browser/ui/passwords/manage_passwords_bubble_model.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/save_password_infobar_delegate.cc

diff --git a/chrome/browser/password_manager/save_password_infobar_delegate.cc b/chrome/browser/password_manager/save_password_infobar_delegate.cc

index de24a40e1491ff45d8604740b3f271887d6abe7b..9c137604e74f62d0a44691bf0a11ca3fea80505f 100644

--- a/chrome/browser/password_manager/save_password_infobar_delegate.cc

+++ b/chrome/browser/password_manager/save_password_infobar_delegate.cc

@@ -22,7 +22,7 @@

// static

void SavePasswordInfoBarDelegate::Create(

content::WebContents* web_contents,

- password_manager::PasswordFormManager* form_to_save,

+ scoped_ptr<password_manager::PasswordFormManager> form_to_save,

const std::string& uma_histogram_suffix) {

#if defined(ENABLE_ONE_CLICK_SIGNIN)

// Don't show the password manager infobar if this form is for a google

@@ -46,7 +46,7 @@ void SavePasswordInfoBarDelegate::Create(

InfoBarService::FromWebContents(web_contents)->AddInfoBar(

SavePasswordInfoBarDelegate::CreateInfoBar(

scoped_ptr<SavePasswordInfoBarDelegate>(

- new SavePasswordInfoBarDelegate(form_to_save,

+ new SavePasswordInfoBarDelegate(form_to_save.Pass(),

uma_histogram_suffix))));

}

@@ -82,10 +82,10 @@ void SavePasswordInfoBarDelegate::SetUseAdditionalPasswordAuthentication(

}

SavePasswordInfoBarDelegate::SavePasswordInfoBarDelegate(

- password_manager::PasswordFormManager* form_to_save,

+ scoped_ptr<password_manager::PasswordFormManager> form_to_save,

const std::string& uma_histogram_suffix)

: ConfirmInfoBarDelegate(),

- form_to_save_(form_to_save),

+ form_to_save_(form_to_save.Pass()),

infobar_response_(password_manager::metrics_util::NO_RESPONSE),

uma_histogram_suffix_(uma_histogram_suffix) {

if (!uma_histogram_suffix_.empty()) {