Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1532)

Unified Diff: chrome/browser/password_manager/chrome_password_manager_client.cc

Issue 399573002: [Password Generation] Trigger confirmation bubble when a password is saved (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Win Again Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/chrome_password_manager_client.cc
diff --git a/chrome/browser/password_manager/chrome_password_manager_client.cc b/chrome/browser/password_manager/chrome_password_manager_client.cc
index 7a9ff5b29ff17cf9ef66d28975574cebaa71076f..df029aee357b8dec1ca6818c1e06058f092054f7 100644
--- a/chrome/browser/password_manager/chrome_password_manager_client.cc
+++ b/chrome/browser/password_manager/chrome_password_manager_client.cc
@@ -109,18 +109,28 @@ bool ChromePasswordManagerClient::IsSyncAccountCredential(
}
void ChromePasswordManagerClient::PromptUserToSavePassword(
- password_manager::PasswordFormManager* form_to_save) {
+ scoped_ptr<password_manager::PasswordFormManager> form_to_save) {
if (IsTheHotNewBubbleUIEnabled()) {
ManagePasswordsUIController* manage_passwords_ui_controller =
ManagePasswordsUIController::FromWebContents(web_contents());
- manage_passwords_ui_controller->OnPasswordSubmitted(form_to_save);
+ manage_passwords_ui_controller->OnPasswordSubmitted(form_to_save.Pass());
} else {
std::string uma_histogram_suffix(
password_manager::metrics_util::GroupIdToString(
password_manager::metrics_util::MonitoredDomainGroupId(
form_to_save->realm(), GetPrefs())));
SavePasswordInfoBarDelegate::Create(
- web_contents(), form_to_save, uma_histogram_suffix);
+ web_contents(), form_to_save.Pass(), uma_histogram_suffix);
+ }
+}
+
+void ChromePasswordManagerClient::AutomaticPasswordSave(
+ scoped_ptr<password_manager::PasswordFormManager> saved_form) {
+ if (IsTheHotNewBubbleUIEnabled()) {
+ ManagePasswordsUIController* manage_passwords_ui_controller =
+ ManagePasswordsUIController::FromWebContents(web_contents());
+ manage_passwords_ui_controller->OnAutomaticPasswordSave(
+ saved_form.Pass());
}
}

Powered by Google App Engine
This is Rietveld 408576698