[Android] Implement ScreenOrientation.unlock align with spec

content/public/android/java/src/org/chromium/content/browser/ScreenOrientationProvider.java

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.content.browser;
 
 import android.app.Activity;
 import android.content.pm.ActivityInfo;
+import android.content.pm.PackageManager;
+import android.content.pm.PackageManager.NameNotFoundException;
 import android.util.Log;
 
 import com.google.common.annotations.VisibleForTesting;
 
 import org.chromium.base.ApplicationStatus;
 import org.chromium.base.CalledByNative;
 import org.chromium.base.JNINamespace;
 import org.chromium.content.common.ScreenOrientationValues;
 
 /**
@@ skipping 48 matching lines @@
         activity.setRequestedOrientation(orientation);
     }
 
     @CalledByNative
     void unlockOrientation() {
         Activity activity = ApplicationStatus.getLastTrackedFocusedActivity();
         if (activity == null) {
             return;
         }
 
-        activity.setRequestedOrientation(ActivityInfo.SCREEN_ORIENTATION_UNSPECIFIED);
+        try {
+            ActivityInfo info = activity.getPackageManager().getActivityInfo(
+                    activity.getComponentName(), PackageManager.GET_META_DATA);
+            activity.setRequestedOrientation(info.screenOrientation);
+        } catch (NameNotFoundException e) {
+            activity.setRequestedOrientation(ActivityInfo.SCREEN_ORIENTATION_UNSPECIFIED);
+        }

[mlamouri (slow - plz ping), 2014/07/16 09:13:42]

I would prefer if the try-catch was only wrapping the lines that need to be
wrapped in there. Could you do:

int defaultOrientation = ActivityInfo.SCREEN_ORIENTATION_UNSPECIFIED;

try {
    ActivityInfo info = activity.getPackageManager().getActivityInfo(
            activity.getComponentName(), PackageManager.GET_META_DATA);
    defaultOrientation = info.screenOrientation;
} catch (PackageManager.NameNotFoundException) {
    // Do nothing, defaultOrientation should be SCREEN_ORIENTATION_UNSPECIFIED.
} finally {
  activity.setRequestedOrientation(defaultOrientation);
}

Note that I think having the full exception name would be better (witch
PackageManager prefix). I guess you might not need for in the import in that
case.

     }
 
     private ScreenOrientationProvider() {
     }
 }