Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1192)

Unified Diff: Source/modules/serviceworkers/ServiceWorkerGlobalScope.h

Issue 399543002: [ServiceWorker] Make fetch() method better conformance with the spec. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/serviceworkers/ServiceWorkerGlobalScope.h
diff --git a/Source/modules/serviceworkers/ServiceWorkerGlobalScope.h b/Source/modules/serviceworkers/ServiceWorkerGlobalScope.h
index 982eea940b551d2c633fa2384d619e24bb2f360e..e76ad69fc410d16920195e6f6f2ca103240c97f1 100644
--- a/Source/modules/serviceworkers/ServiceWorkerGlobalScope.h
+++ b/Source/modules/serviceworkers/ServiceWorkerGlobalScope.h
@@ -36,6 +36,7 @@
namespace WebCore {
+class Dictionary;
class FetchManager;
class Request;
class ScriptPromise;
@@ -56,7 +57,9 @@ public:
PassRefPtrWillBeRawPtr<ServiceWorkerClients> clients();
String scope(ExecutionContext*);
ScriptPromise fetch(ScriptState*, Request*);
+ ScriptPromise fetch(ScriptState*, Request*, const Dictionary&);
ScriptPromise fetch(ScriptState*, const String&);
+ ScriptPromise fetch(ScriptState*, const String&, const Dictionary&);
// EventTarget
virtual const AtomicString& interfaceName() const OVERRIDE;
@@ -72,6 +75,7 @@ public:
private:
ServiceWorkerGlobalScope(const KURL&, const String& userAgent, ServiceWorkerThread*, double timeOrigin, PassOwnPtrWillBeRawPtr<WorkerClients>);
virtual void logExceptionToConsole(const String& errorMessage, const String& sourceURL, int lineNumber, int columnNumber, PassRefPtrWillBeRawPtr<ScriptCallStack>) OVERRIDE;
+ ScriptPromise fetch(ScriptState*, PassRefPtr<Request>);
yhirano 2014/07/16 13:12:27 Can you rename this function to another name (e.g.
horo 2014/07/18 09:12:18 It should be deleted. I deleted it.
RefPtrWillBeMember<ServiceWorkerClients> m_clients;
OwnPtr<FetchManager> m_fetchManager;

Powered by Google App Engine
This is Rietveld 408576698