Source/core/timing/Performance.cpp - Issue 399543002: [ServiceWorker] Make fetch() method better conformance with the spec.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/timing/Performance.cpp

Issue 399543002: [ServiceWorker] Make fetch() method better conformance with the spec. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/loader/DocumentThreadableLoader.cpp ('K') | « Source/core/loader/DocumentThreadableLoader.cpp ('k') | Source/modules/serviceworkers/FetchHeaderList.h » ('j') | Source/modules/serviceworkers/FetchManager.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/timing/Performance.cpp

diff --git a/Source/core/timing/Performance.cpp b/Source/core/timing/Performance.cpp

index 6029829a1130437d17209a9b95938227867f6139..f61b5a0e6125c18e4657c6236b7f6afe9cb79196 100644

--- a/Source/core/timing/Performance.cpp

+++ b/Source/core/timing/Performance.cpp

@@ -214,7 +214,9 @@ void Performance::addResourceTiming(const ResourceTimingInfo& info, Document* in

const Vector<ResourceResponse>& redirectChain = info.redirectChain();

bool allowRedirectDetails = allowsTimingRedirect(redirectChain, finalResponse, initiatorDocument);

- if (!allowRedirectDetails) {

+ // ServiceWorker doesn't support TimingInfo.

+ // FIXME: Implement ServiceWorkerURLRequestJob::GetLoadTimingInfo().

+ if (!allowRedirectDetails && !finalResponse.wasFetchedViaServiceWorker()) {

ResourceLoadTiming* finalTiming = finalResponse.resourceLoadTiming();

ASSERT(finalTiming);

if (finalTiming)