Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(659)

Side by Side Diff: Source/web/ServiceWorkerGlobalScopeClientImpl.cpp

Issue 399543002: [ServiceWorker] Make fetch() method better conformance with the spec. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: incorporated falken's comment Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/modules/serviceworkers/ServiceWorkerGlobalScope.idl ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2014 Google Inc. All rights reserved. 2 * Copyright (C) 2014 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
73 73
74 void ServiceWorkerGlobalScopeClientImpl::didHandleFetchEvent(int fetchEventID, P assRefPtrWillBeRawPtr<Response> response) 74 void ServiceWorkerGlobalScopeClientImpl::didHandleFetchEvent(int fetchEventID, P assRefPtrWillBeRawPtr<Response> response)
75 { 75 {
76 if (!response) { 76 if (!response) {
77 m_client.didHandleFetchEvent(fetchEventID); 77 m_client.didHandleFetchEvent(fetchEventID);
78 return; 78 return;
79 } 79 }
80 80
81 WebServiceWorkerResponse webResponse; 81 WebServiceWorkerResponse webResponse;
82 response->populateWebServiceWorkerResponse(webResponse); 82 response->populateWebServiceWorkerResponse(webResponse);
83 if (webResponse.status() == 0) {
84 // The status code is 0 means a network error.
85 m_client.didHandleFetchEvent(fetchEventID);
86 return;
87 }
83 m_client.didHandleFetchEvent(fetchEventID, webResponse); 88 m_client.didHandleFetchEvent(fetchEventID, webResponse);
84 } 89 }
85 90
86 void ServiceWorkerGlobalScopeClientImpl::didHandleSyncEvent(int syncEventID) 91 void ServiceWorkerGlobalScopeClientImpl::didHandleSyncEvent(int syncEventID)
87 { 92 {
88 m_client.didHandleSyncEvent(syncEventID); 93 m_client.didHandleSyncEvent(syncEventID);
89 } 94 }
90 95
91 void ServiceWorkerGlobalScopeClientImpl::postMessageToClient(int clientID, const WebString& message, PassOwnPtr<WebMessagePortChannelArray> webChannels) 96 void ServiceWorkerGlobalScopeClientImpl::postMessageToClient(int clientID, const WebString& message, PassOwnPtr<WebMessagePortChannelArray> webChannels)
92 { 97 {
93 m_client.postMessageToClient(clientID, message, webChannels.leakPtr()); 98 m_client.postMessageToClient(clientID, message, webChannels.leakPtr());
94 } 99 }
95 100
96 ServiceWorkerGlobalScopeClientImpl::ServiceWorkerGlobalScopeClientImpl(WebServic eWorkerContextClient& client) 101 ServiceWorkerGlobalScopeClientImpl::ServiceWorkerGlobalScopeClientImpl(WebServic eWorkerContextClient& client)
97 : m_client(client) 102 : m_client(client)
98 { 103 {
99 } 104 }
100 105
101 } // namespace blink 106 } // namespace blink
OLDNEW
« no previous file with comments | « Source/modules/serviceworkers/ServiceWorkerGlobalScope.idl ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698