LayoutTests/http/tests/serviceworker/resources/fetch-access-control-login.html - Issue 399543002: [ServiceWorker] Make fetch() method better conformance with the spec.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/http/tests/serviceworker/resources/fetch-access-control-login.html

Issue 399543002: [ServiceWorker] Make fetch() method better conformance with the spec. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: indent and comment fix Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/http/tests/serviceworker/resources/fetch-access-control-iframe.html ('K') | « LayoutTests/http/tests/serviceworker/resources/fetch-access-control-iframe.html ('k') | LayoutTests/http/tests/serviceworker/resources/fetch-access-control-worker.js » ('j') | LayoutTests/http/tests/serviceworker/resources/fetch-access-control-worker.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <script>

	2 // Set authentication info

	3 window.addEventListener("message", function(evt) {

	4 var port = evt.ports[0];

	5 var xhr = new XMLHttpRequest();

	6 xhr.addEventListener('load', function() {

	7 port.postMessage({msg: 'LOGIN FINISHED'});

	8 }, false);
	falken 2014/07/25 05:41:29 indent this by 2 space indent this by 2 space horo 2014/07/25 06:00:56 Done. Show quoted text On 2014/07/25 05:41:29, falken wrote: > indent this by 2 space Done.
	9 xhr.open('GET',

	10 './fetch-access-control.php?Auth',

	11 true,

	12 evt.data.username, evt.data.password);

	13 xhr.send();

	14 }, false);
	falken 2014/07/25 05:41:29 new style guide indents this line by 2 space new style guide indents this line by 2 space horo 2014/07/25 06:00:56 Done. Show quoted text On 2014/07/25 05:41:29, falken wrote: > new style guide indents this line by 2 space Done.
	15 </script>

OLD	NEW