Shorten gyp target names for PNaCl IRT shim

Shorten gyp target names for PNaCl IRT shim

These are basically the longest generated names, and the trybots appear
to have shorter overall names than the buildbots, because try jobs pass
and then the builders break.

R=jvoung@chromium.org
TBR=binji@chromium.org, teravest@chromium.org
BUG= https://code.google.com/p/nativeclient/issues/detail?id=3846

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283402

[jvoung (off chromium), 2014-07-16 00:19:24]

A bit worried that this will trip up again eventually. I guess response files
don't help?

Otherwise, another suggestion is to remove the "newlib" component from the
directory names like "pnacl_newlib_x86_32-nonsfi...", or rename the directory
"pnacl_irt_shim" -> "pnacl_shim" (might need to change the IDL generator /
presubmit hooks).

https://codereview.chromium.org/399523002/diff/1/ppapi/native_client/src/untr...
File ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_irt_shim.gyp
(right):

https://codereview.chromium.org/399523002/diff/1/ppapi/native_client/src/untr...
ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_irt_shim.gyp:63:
'out_pnacl_newlib_arm':
'>(tc_lib_dir_pnacl_translate)/lib-arm/for_browser/>(nlib_target)',
Hmm... are you going to have problems when it hits this "for_browser" case too?

for_browser -> browser

or brwsr

[Derek Schuff, 2014-07-16 00:22:54]

On 2014/07/16 00:19:24, jvoung wrote:
> A bit worried that this will trip up again eventually. I guess response files
> don't help?

So am I. And no, not as far as I know. It seems especially bad because the
(relative) file names actually failing are only like 170 chars while the limit
is like 260. Presumably the expanded name is longer.
We should investigate more but I really want to get the switch to mingw in first
to avoid having that still
in flight.

> Otherwise, another suggestion is to remove the "newlib" component from the
> directory names like "pnacl_newlib_x86_32-nonsfi...", or rename the directory
> "pnacl_irt_shim" -> "pnacl_shim" (might need to change the IDL generator /
> presubmit hooks).

That's a good idea too. I went for target names because they are expanded twice
into the pathname, but they 
are becoming pretty short.
 
>
https://codereview.chromium.org/399523002/diff/1/ppapi/native_client/src/untr...
> File ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_irt_shim.gyp
> (right):
> 
>
https://codereview.chromium.org/399523002/diff/1/ppapi/native_client/src/untr...
> ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_irt_shim.gyp:63:
> 'out_pnacl_newlib_arm':
> '>(tc_lib_dir_pnacl_translate)/lib-arm/for_browser/>(nlib_target)',
> Hmm... are you going to have problems when it hits this "for_browser" case
too?

Yeah, see patchset 2.

[jvoung (off chromium), 2014-07-16 00:26:23]

Otherwise LGTM

https://codereview.chromium.org/399523002/diff/1/ppapi/native_client/src/untr...
File ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_irt_shim.gyp
(right):

https://codereview.chromium.org/399523002/diff/1/ppapi/native_client/src/untr...
ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_irt_shim.gyp:63:
'out_pnacl_newlib_arm':
'>(tc_lib_dir_pnacl_translate)/lib-arm/for_browser/>(nlib_target)',
On 2014/07/16 00:19:24, jvoung wrote:
> Hmm... are you going to have problems when it hits this "for_browser" case
too?
> 
> for_browser -> browser
> 
> or brwsr

I don't think patchset 2 changed the ../for_browser/... subdir, but it might be
good to shorten that too.

https://codereview.chromium.org/399523002/diff/20001/ppapi/native_client/src/...
File
ppapi/native_client/src/untrusted/pnacl_support_extension/pnacl_support_extension.gyp
(right):

https://codereview.chromium.org/399523002/diff/20001/ppapi/native_client/src/...
ppapi/native_client/src/untrusted/pnacl_support_extension/pnacl_support_extension.gyp:80:
'>(tc_lib_dir_pnacl_translate)/lib-x86-32/for_browser/libpnacl_irt_shim.a',
You could change these /for_browser/ too

[Derek Schuff, 2014-07-16 00:28:44]

https://codereview.chromium.org/399523002/diff/1/ppapi/native_client/src/untr...
> > ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_irt_shim.gyp:63:
> > 'out_pnacl_newlib_arm':
> > '>(tc_lib_dir_pnacl_translate)/lib-arm/for_browser/>(nlib_target)',
> > Hmm... are you going to have problems when it hits this "for_browser" case
> too?
> 
> Yeah, see patchset 2.

Oh, sorry I misunderstood you. most of the problems seem to be with the driver
temp files, but hey, it can't hurt. anything to get this damn switch landed for
now.

[Derek Schuff, 2014-07-16 00:36:59]

The CQ bit was checked by dschuff@chromium.org

[commit-bot: I haz the power, 2014-07-16 00:41:19]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dschuff@chromium.org/399523002/40001

[Derek Schuff, 2014-07-16 15:52:53]

Committed patchset #3 manually as r283402 (presubmit successful).