Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1123)

Issue 399473006: Reland "Make v8::TryCatch able to consume natively thrown exceptions." (Closed)

Created:
6 years, 5 months ago by Michael Starzinger
Modified:
6 years, 5 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Reland "Make v8::TryCatch able to consume natively thrown exceptions." R=svenpanne@chromium.org BUG=chromium:362388 TEST=cctest/test-api/TryCatchNative LOG=N Committed: https://code.google.com/p/v8/source/detail?r=22481

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -11 lines) Patch
M src/api.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/isolate.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/isolate.cc View 3 chunks +11 lines, -4 lines 0 comments Download
M test/cctest/test-api.cc View 3 chunks +54 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Starzinger
6 years, 5 months ago (2014-07-18 08:59:02 UTC) #1
Michael Starzinger
Yang is OOO today, switching reviewer to Sven instead. PTAL.
6 years, 5 months ago (2014-07-18 09:17:37 UTC) #2
Sven Panne
LGTM (rubber-stamped)
6 years, 5 months ago (2014-07-18 11:52:12 UTC) #3
Michael Starzinger
6 years, 5 months ago (2014-07-18 13:28:27 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r22481 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698