Maintain Diamond (F15) modifier state when rewriting.

Maintain Diamond (F15) state when rewriting.

The ChromeOS Diamond key arrives as F15. Since F15 is not a modifier,
we need to track its pressed state explicitly, and apply the selected
modifier flag to key and mouse presses that arrive while F15 is down.
(Maintaining and applying the modifier state in the rewriter is
consistent with how the sticky keys feature is implemented.)

TEST=EventRewriterTest.TestRewriteDiamondKey*
BUG=390982
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283791

[Daniel Erat, 2014-07-15 23:53:25]

lgtm

https://codereview.chromium.org/399443004/diff/1/chrome/browser/chromeos/even...
File chrome/browser/chromeos/events/event_rewriter.h (right):

https://codereview.chromium.org/399443004/diff/1/chrome/browser/chromeos/even...
chrome/browser/chromeos/events/event_rewriter.h:188: int
active_diamond_modifier_;
nit: document what this actually holds (i.e. an event flags bitmap), and a name
like |current_diamond_key_modifier_flags_| may be a bit clearer

[sadrul, 2014-07-16 05:02:19]

rslgtm

[kpschoedel, 2014-07-16 14:19:38]

The CQ bit was checked by kpschoedel@chromium.org

[commit-bot: I haz the power, 2014-07-16 14:22:14]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kpschoedel@chromium.org/399443004/1

[Daniel Erat, 2014-07-16 14:42:53]

The CQ bit was unchecked by derat@chromium.org

[Daniel Erat, 2014-07-16 14:43:11]

(sorry, unchecking cq bit since i think you didn't see my comment)

[kpschoedel, 2014-07-16 14:46:40]

On 2014/07/16 14:43:11, Daniel Erat wrote:
> (sorry, unchecking cq bit since i think you didn't see my comment)

Ah, thanks; I did see it last night but forgot this morning.

[kpschoedel, 2014-07-16 15:12:28]

https://codereview.chromium.org/399443004/diff/1/chrome/browser/chromeos/even...
File chrome/browser/chromeos/events/event_rewriter.h (right):

https://codereview.chromium.org/399443004/diff/1/chrome/browser/chromeos/even...
chrome/browser/chromeos/events/event_rewriter.h:188: int
active_diamond_modifier_;
On 2014/07/15 23:53:25, Daniel Erat wrote:
> nit: document what this actually holds (i.e. an event flags bitmap), and a
name
> like |current_diamond_key_modifier_flags_| may be a bit clearer

Done.

[Daniel Erat, 2014-07-16 15:22:12]

lgtm

[kpschoedel, 2014-07-16 16:38:28]

The CQ bit was checked by kpschoedel@chromium.org

[commit-bot: I haz the power, 2014-07-16 16:40:10]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kpschoedel@chromium.org/399443004/50001

[commit-bot: I haz the power, 2014-07-16 19:22:01]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-07-17 09:24:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-17 09:24:40]

Try jobs failed on following builders:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[kpschoedel, 2014-07-17 15:04:37]

The CQ bit was checked by kpschoedel@chromium.org

[commit-bot: I haz the power, 2014-07-17 15:05:16]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kpschoedel@chromium.org/399443004/50001

[commit-bot: I haz the power, 2014-07-17 16:20:45]

Change committed as 283791