Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Side by Side Diff: extensions/browser/extension_prefs.cc

Issue 399433005: Extirpate CreateBooleanValue. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: s/boolean/bool Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « components/pref_registry/pref_registry_syncable.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/browser/extension_prefs.h" 5 #include "extensions/browser/extension_prefs.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 8
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/prefs/pref_notifier.h" 10 #include "base/prefs/pref_notifier.h"
(...skipping 702 matching lines...) Expand 10 before | Expand all | Expand 10 after
713 } 713 }
714 714
715 bool ExtensionPrefs::HasWipeoutBeenAcknowledged( 715 bool ExtensionPrefs::HasWipeoutBeenAcknowledged(
716 const std::string& extension_id) { 716 const std::string& extension_id) {
717 return ReadPrefAsBooleanAndReturn(extension_id, kPrefWipeoutAcknowledged); 717 return ReadPrefAsBooleanAndReturn(extension_id, kPrefWipeoutAcknowledged);
718 } 718 }
719 719
720 void ExtensionPrefs::SetWipeoutAcknowledged( 720 void ExtensionPrefs::SetWipeoutAcknowledged(
721 const std::string& extension_id, 721 const std::string& extension_id,
722 bool value) { 722 bool value) {
723 UpdateExtensionPref(extension_id, kPrefWipeoutAcknowledged, 723 UpdateExtensionPref(extension_id,
724 value ? base::Value::CreateBooleanValue(value) : NULL); 724 kPrefWipeoutAcknowledged,
725 value ? new base::FundamentalValue(value) : NULL);
725 } 726 }
726 727
727 bool ExtensionPrefs::HasSettingsApiBubbleBeenAcknowledged( 728 bool ExtensionPrefs::HasSettingsApiBubbleBeenAcknowledged(
728 const std::string& extension_id) { 729 const std::string& extension_id) {
729 return ReadPrefAsBooleanAndReturn(extension_id, 730 return ReadPrefAsBooleanAndReturn(extension_id,
730 kPrefSettingsBubbleAcknowledged); 731 kPrefSettingsBubbleAcknowledged);
731 } 732 }
732 733
733 void ExtensionPrefs::SetSettingsApiBubbleBeenAcknowledged( 734 void ExtensionPrefs::SetSettingsApiBubbleBeenAcknowledged(
734 const std::string& extension_id, 735 const std::string& extension_id,
735 bool value) { 736 bool value) {
736 UpdateExtensionPref(extension_id, 737 UpdateExtensionPref(extension_id,
737 kPrefSettingsBubbleAcknowledged, 738 kPrefSettingsBubbleAcknowledged,
738 value ? base::Value::CreateBooleanValue(value) : NULL); 739 value ? new base::FundamentalValue(value) : NULL);
739 } 740 }
740 741
741 bool ExtensionPrefs::HasNtpOverriddenBubbleBeenAcknowledged( 742 bool ExtensionPrefs::HasNtpOverriddenBubbleBeenAcknowledged(
742 const std::string& extension_id) { 743 const std::string& extension_id) {
743 return ReadPrefAsBooleanAndReturn(extension_id, kPrefNtpBubbleAcknowledged); 744 return ReadPrefAsBooleanAndReturn(extension_id, kPrefNtpBubbleAcknowledged);
744 } 745 }
745 746
746 void ExtensionPrefs::SetNtpOverriddenBubbleBeenAcknowledged( 747 void ExtensionPrefs::SetNtpOverriddenBubbleBeenAcknowledged(
747 const std::string& extension_id, 748 const std::string& extension_id,
748 bool value) { 749 bool value) {
749 UpdateExtensionPref(extension_id, 750 UpdateExtensionPref(extension_id,
750 kPrefNtpBubbleAcknowledged, 751 kPrefNtpBubbleAcknowledged,
751 value ? base::Value::CreateBooleanValue(value) : NULL); 752 value ? new base::FundamentalValue(value) : NULL);
752 } 753 }
753 754
754 bool ExtensionPrefs::HasProxyOverriddenBubbleBeenAcknowledged( 755 bool ExtensionPrefs::HasProxyOverriddenBubbleBeenAcknowledged(
755 const std::string& extension_id) { 756 const std::string& extension_id) {
756 return ReadPrefAsBooleanAndReturn(extension_id, kPrefProxyBubbleAcknowledged); 757 return ReadPrefAsBooleanAndReturn(extension_id, kPrefProxyBubbleAcknowledged);
757 } 758 }
758 759
759 void ExtensionPrefs::SetProxyOverriddenBubbleBeenAcknowledged( 760 void ExtensionPrefs::SetProxyOverriddenBubbleBeenAcknowledged(
760 const std::string& extension_id, 761 const std::string& extension_id,
761 bool value) { 762 bool value) {
762 UpdateExtensionPref(extension_id, 763 UpdateExtensionPref(extension_id,
763 kPrefProxyBubbleAcknowledged, 764 kPrefProxyBubbleAcknowledged,
764 value ? base::Value::CreateBooleanValue(value) : NULL); 765 value ? new base::FundamentalValue(value) : NULL);
765 } 766 }
766 767
767 bool ExtensionPrefs::SetAlertSystemFirstRun() { 768 bool ExtensionPrefs::SetAlertSystemFirstRun() {
768 if (prefs_->GetBoolean(pref_names::kAlertsInitialized)) { 769 if (prefs_->GetBoolean(pref_names::kAlertsInitialized)) {
769 return true; 770 return true;
770 } 771 }
771 prefs_->SetBoolean(pref_names::kAlertsInitialized, true); 772 prefs_->SetBoolean(pref_names::kAlertsInitialized, true);
772 return false; 773 return false;
773 } 774 }
774 775
(...skipping 1410 matching lines...) Expand 10 before | Expand all | Expand 10 after
2185 extension_pref_value_map_->RegisterExtension( 2186 extension_pref_value_map_->RegisterExtension(
2186 extension_id, install_time, is_enabled, is_incognito_enabled); 2187 extension_id, install_time, is_enabled, is_incognito_enabled);
2187 2188
2188 FOR_EACH_OBSERVER( 2189 FOR_EACH_OBSERVER(
2189 ExtensionPrefsObserver, 2190 ExtensionPrefsObserver,
2190 observer_list_, 2191 observer_list_,
2191 OnExtensionRegistered(extension_id, install_time, is_enabled)); 2192 OnExtensionRegistered(extension_id, install_time, is_enabled));
2192 } 2193 }
2193 2194
2194 } // namespace extensions 2195 } // namespace extensions
OLDNEW
« no previous file with comments | « components/pref_registry/pref_registry_syncable.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698