Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(908)

Unified Diff: media/formats/mp2t/es_parser_adts_unittest.cc

Issue 399433003: Mpeg2 TS - Fail when no valid timestamp in the ADTS parser. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix rebase: do not set dts in adts parser. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/formats/mp2t/es_parser_adts.cc ('k') | media/formats/mp2t/es_parser_h264_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/formats/mp2t/es_parser_adts_unittest.cc
diff --git a/media/formats/mp2t/es_parser_adts_unittest.cc b/media/formats/mp2t/es_parser_adts_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..c9dd47c54b486c014dbd4281472ad24fe0c4a03f
--- /dev/null
+++ b/media/formats/mp2t/es_parser_adts_unittest.cc
@@ -0,0 +1,86 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include <vector>
+
+#include "base/bind.h"
+#include "base/logging.h"
+#include "base/time/time.h"
+#include "media/base/buffers.h"
+#include "media/base/stream_parser_buffer.h"
+#include "media/formats/mp2t/es_parser_adts.h"
+#include "media/formats/mp2t/es_parser_test_base.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace media {
+class AudioDecoderConfig;
+
+namespace mp2t {
+
+class EsParserAdtsTest : public EsParserTestBase,
+ public testing::Test {
+ public:
+ EsParserAdtsTest();
+ virtual ~EsParserAdtsTest() {}
+
+ protected:
+ bool Process(const std::vector<Packet>& pes_packets, bool force_timing);
+
+ std::vector<Packet> GenerateFixedSizePesPacket(size_t pes_size);
+
+ private:
+ DISALLOW_COPY_AND_ASSIGN(EsParserAdtsTest);
+};
+
+EsParserAdtsTest::EsParserAdtsTest() {
+}
+
+bool EsParserAdtsTest::Process(
+ const std::vector<Packet>& pes_packets,
+ bool force_timing) {
+ EsParserAdts es_parser(
+ base::Bind(&EsParserAdtsTest::NewAudioConfig, base::Unretained(this)),
+ base::Bind(&EsParserAdtsTest::EmitBuffer, base::Unretained(this)),
+ false);
+ return ProcessPesPackets(&es_parser, pes_packets, force_timing);
+}
+
+std::vector<EsParserTestBase::Packet>
+EsParserAdtsTest::GenerateFixedSizePesPacket(size_t pes_size) {
+ DCHECK_GT(stream_.size(), 0u);
+ std::vector<Packet> pes_packets;
+
+ Packet cur_pes_packet;
+ cur_pes_packet.offset = 0;
+ cur_pes_packet.pts = kNoTimestamp();
+ while (cur_pes_packet.offset < stream_.size()) {
+ pes_packets.push_back(cur_pes_packet);
+ cur_pes_packet.offset += pes_size;
+ }
+ ComputePacketSize(&pes_packets);
+
+ return pes_packets;
+}
+
+TEST_F(EsParserAdtsTest, NoInitialPts) {
+ LoadStream("bear.adts");
+ std::vector<Packet> pes_packets = GenerateFixedSizePesPacket(512);
+ EXPECT_FALSE(Process(pes_packets, false));
+ EXPECT_EQ(0u, buffer_count_);
+}
+
+TEST_F(EsParserAdtsTest, SinglePts) {
+ LoadStream("bear.adts");
+
+ std::vector<Packet> pes_packets = GenerateFixedSizePesPacket(512);
+ pes_packets.front().pts = base::TimeDelta::FromSeconds(10);
+
+ EXPECT_TRUE(Process(pes_packets, false));
+ EXPECT_EQ(1u, config_count_);
+ EXPECT_EQ(45u, buffer_count_);
+}
+
+} // namespace mp2t
+} // namespace media
+
« no previous file with comments | « media/formats/mp2t/es_parser_adts.cc ('k') | media/formats/mp2t/es_parser_h264_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698