Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(612)

Issue 399433002: Update OmniboxEvent Proto File (Closed)

Created:
6 years, 5 months ago by Mark P
Modified:
6 years, 5 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Update OmniboxEvent Proto File To correspond to changes made in internal change 70990265. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284214

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M components/metrics/proto/omnibox_event.proto View 3 chunks +13 lines, -1 line 0 comments Download

Messages

Total messages: 23 (0 generated)
Mark P
Please take a look, thanks. --mark
6 years, 5 months ago (2014-07-15 18:26:29 UTC) #1
Ilya Sherman
LGTM
6 years, 5 months ago (2014-07-15 22:26:08 UTC) #2
Mark P
The CQ bit was checked by mpearson@chromium.org
6 years, 5 months ago (2014-07-15 23:31:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpearson@chromium.org/399433002/1
6 years, 5 months ago (2014-07-15 23:33:52 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-16 07:59:19 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-16 08:19:20 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/171186)
6 years, 5 months ago (2014-07-16 08:19:21 UTC) #7
Mark P
The CQ bit was checked by mpearson@chromium.org
6 years, 5 months ago (2014-07-17 19:05:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpearson@chromium.org/399433002/1
6 years, 5 months ago (2014-07-17 19:11:55 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-17 19:37:27 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-17 19:57:14 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/171478)
6 years, 5 months ago (2014-07-17 19:57:15 UTC) #12
Mark P
The CQ bit was checked by mpearson@chromium.org
6 years, 5 months ago (2014-07-17 20:01:00 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpearson@chromium.org/399433002/1
6 years, 5 months ago (2014-07-17 20:03:22 UTC) #14
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-17 22:18:17 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-17 22:39:01 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/172161)
6 years, 5 months ago (2014-07-17 22:39:02 UTC) #17
Mark P
The CQ bit was checked by mpearson@chromium.org
6 years, 5 months ago (2014-07-18 17:58:20 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpearson@chromium.org/399433002/1
6 years, 5 months ago (2014-07-18 18:00:21 UTC) #19
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 5 months ago (2014-07-18 18:25:51 UTC) #20
Mark P
The CQ bit was checked by mpearson@chromium.org
6 years, 5 months ago (2014-07-18 19:00:39 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpearson@chromium.org/399433002/20001
6 years, 5 months ago (2014-07-18 19:00:54 UTC) #22
commit-bot: I haz the power
6 years, 5 months ago (2014-07-18 22:01:09 UTC) #23
Message was sent while issue was closed.
Change committed as 284214

Powered by Google App Engine
This is Rietveld 408576698