Issue 399423006: Move widow-avoiding code from RenderBlock down to RenderBlockFlow.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 399423006: Move widow-avoiding code from RenderBlock down to RenderBlockFlow. (Closed)

Created:
6 years, 5 months ago by jbroman

Modified:
6 years, 5 months ago

Reviewers:
leviw_travelin_and_unemployed, eseidel, Julien - ping for review

CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr., rune+blink, zoltan1

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

Move widow-avoiding code from RenderBlock down to RenderBlockFlow. BUG=302024 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178468

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+49 lines, -53 lines)			Patch
M	Source/core/rendering/RenderBlock.h	View	2 chunks	+0 lines, -13 lines	0 comments	Download
M	Source/core/rendering/RenderBlock.cpp	View	2 chunks	+0 lines, -39 lines	0 comments	Download
M	Source/core/rendering/RenderBlockFlow.h	View	3 chunks	+12 lines, -0 lines	0 comments	Download
M	Source/core/rendering/RenderBlockFlow.cpp	View	2 chunks	+37 lines, -1 line	0 comments	Download

Total messages: 4 (0 generated)

jbroman

If this looks good, a subsequent patch can move the remaining value in RenderBlockRareData into ...

6 years, 5 months ago (2014-07-18 15:40:22 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbroman@chromium.org/399423006/1

6 years, 5 months ago (2014-07-18 17:55:27 UTC) #3

Message was sent while issue was closed.

Change committed as 178468