Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Issue 399423005: Change instant event phase name from i to I (Closed)

Created:
6 years, 5 months ago by yurys
Modified:
6 years, 5 months ago
Reviewers:
caseq, nduca, alph, loislo, dsinclair
CC:
chromium-reviews, dsinclair+watch_chromium.org, erikwright+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Change instant event phase name from i to I This matches current definition in the design doc[1] and unifies phase name between Chromium and Blink. Telemetry already expects both "i" and "I" values [2]. It used to be "I" in Chromium but it was changed in https://chromiumcodereview.appspot.com/12252058/ [1] https://docs.google.com/a/chromium.org/document/d/1CvAClvFfyA5R-PhYUmn5OOQtYMH4h6I0nSsKchNAySU/edit# [2] https://code.google.com/p/chromium/codesearch#chromium/src/tools/telemetry/telemetry/timeline/trace_event_importer.py&q=%22elif%20phase%20==%20'I'%20or%20phase%20==%20'i':%22&sq=package:chromium&type=cs&l=252 BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284644

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M base/debug/trace_event.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
yurys
6 years, 5 months ago (2014-07-21 05:47:13 UTC) #1
yurys
6 years, 5 months ago (2014-07-21 06:38:18 UTC) #2
yurys
6 years, 5 months ago (2014-07-21 07:20:38 UTC) #3
yurys
@dsinclair: please take a look. Alternatively I can change this on Blink side to use ...
6 years, 5 months ago (2014-07-21 14:14:52 UTC) #4
dsinclair
lgtm
6 years, 5 months ago (2014-07-21 14:30:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yurys@chromium.org/399423005/1
6 years, 5 months ago (2014-07-21 14:31:42 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_dbg_simulator on tryserver.chromium ...
6 years, 5 months ago (2014-07-21 15:54:46 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-21 15:57:16 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/builds/172099)
6 years, 5 months ago (2014-07-21 15:57:17 UTC) #9
yurys
The CQ bit was checked by yurys@chromium.org
6 years, 5 months ago (2014-07-22 07:01:19 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yurys@chromium.org/399423005/1
6 years, 5 months ago (2014-07-22 07:01:34 UTC) #11
commit-bot: I haz the power
6 years, 5 months ago (2014-07-22 07:19:30 UTC) #12
Message was sent while issue was closed.
Change committed as 284644

Powered by Google App Engine
This is Rietveld 408576698