Issue 399413002: Fix the android_webview build's gyp files after the changes in r22444.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 399413002: Fix the android_webview build's gyp files after the changes in r22444. (Closed)

Created:
6 years, 5 months ago by rmcilroy

Modified:
6 years, 5 months ago

Reviewers:
Michael Achenbach, Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Fix the android_webview build's gyp files after the changes in r22444. The android_webview get's it's compiler flags from the Android build system, so we should not be setting these flags in gyp when building the webview. R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22467

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -5 lines)			Patch
	M	build/toolchain.gypi	View		5 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

rmcilroy

I think this should fix the issue you were seeing in http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/93944/steps/compile/logs/stdio PTAL.

6 years, 5 months ago (2014-07-18 09:55:11 UTC) #1

rmcilroy

6 years, 5 months ago (2014-07-18 10:17:07 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r22467 (presubmit successful).

Expand Messages | Collapse Messages