Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(761)

Issue 399393002: Add CSS Transitions performance tests (Closed)

Created:
6 years, 5 months ago by alancutter (OOO until 2018)
Modified:
6 years, 2 months ago
Reviewers:
dtu, tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Add CSS Transitions performance tests This adds several performance tests for CSS Transitions initiated in various ways. BUG=309981, 421733 Committed: https://crrev.com/cd92ffb4655e9ccedaf19d3a787c874b847f89ac Cr-Commit-Position: refs/heads/master@{#299417}

Patch Set 1 #

Patch Set 2 : Reduce duplication #

Patch Set 3 : Appease linter #

Unified diffs Side-by-side diffs Delta from patch set Stats (+693 lines, -6 lines) Patch
M tools/perf/page_sets/tough_animation_cases.py View 1 2 2 chunks +50 lines, -2 lines 0 comments Download
A tools/perf/page_sets/tough_animation_cases/css_transitions_simultaneous_by_inserting_new_elements.html View 1 chunk +51 lines, -0 lines 0 comments Download
A tools/perf/page_sets/tough_animation_cases/css_transitions_simultaneous_by_inserting_style_element.html View 1 chunk +34 lines, -0 lines 0 comments Download
A tools/perf/page_sets/tough_animation_cases/css_transitions_simultaneous_by_updating_class.html View 1 chunk +40 lines, -0 lines 0 comments Download
A tools/perf/page_sets/tough_animation_cases/css_transitions_simultaneous_by_updating_inline_style.html View 1 chunk +33 lines, -0 lines 0 comments Download
A tools/perf/page_sets/tough_animation_cases/css_transitions_staggered_chaining_by_inserting_new_element.html View 1 chunk +54 lines, -0 lines 0 comments Download
A tools/perf/page_sets/tough_animation_cases/css_transitions_staggered_chaining_by_inserting_style_element.html View 1 chunk +55 lines, -0 lines 0 comments Download
A tools/perf/page_sets/tough_animation_cases/css_transitions_staggered_chaining_by_updating_class.html View 1 chunk +48 lines, -0 lines 0 comments Download
A tools/perf/page_sets/tough_animation_cases/css_transitions_staggered_chaining_by_updating_inline_style.html View 1 chunk +42 lines, -0 lines 0 comments Download
A tools/perf/page_sets/tough_animation_cases/css_transitions_staggered_triggering_by_inserting_new_element.html View 1 chunk +61 lines, -0 lines 0 comments Download
A tools/perf/page_sets/tough_animation_cases/css_transitions_staggered_triggering_by_inserting_style.html View 1 2 1 chunk +76 lines, -0 lines 0 comments Download
A tools/perf/page_sets/tough_animation_cases/css_transitions_staggered_triggering_by_updating_class.html View 1 chunk +53 lines, -0 lines 0 comments Download
A tools/perf/page_sets/tough_animation_cases/css_transitions_staggered_triggering_by_updating_inline_style.html View 1 chunk +46 lines, -0 lines 0 comments Download
M tools/perf/page_sets/tough_animation_cases/overlay_background_color_css_transitions.html View 1 2 chunks +2 lines, -2 lines 0 comments Download
M tools/perf/page_sets/tough_animation_cases/resources/perftesthelper.js View 1 chunk +22 lines, -0 lines 0 comments Download
A tools/perf/page_sets/tough_animation_cases/resources/tablet.css View 1 2 1 chunk +24 lines, -0 lines 0 comments Download
A + tools/perf/page_sets/tough_animation_cases/resources/transition.css View 1 2 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (3 generated)
alancutter (OOO until 2018)
These tests fail to initialise on Android Nexus 7 when the overlay_background_color_css_transitions.html test is present. ...
6 years, 5 months ago (2014-07-18 09:29:41 UTC) #1
dtu
On 2014/07/18 09:29:41, alancutter wrote: > These tests fail to initialise on Android Nexus 7 ...
6 years, 5 months ago (2014-07-24 23:45:50 UTC) #2
alancutter (OOO until 2018)
On 2014/07/24 23:45:50, dtu wrote: > On 2014/07/18 09:29:41, alancutter wrote: > > These tests ...
6 years, 5 months ago (2014-07-25 05:00:54 UTC) #3
dtu
lgtm
6 years, 4 months ago (2014-07-29 22:20:54 UTC) #4
alancutter (OOO until 2018)
On 2014/07/29 22:20:54, dtu wrote: > lgtm Ran this change through the perf_bisect bots to ...
6 years, 2 months ago (2014-10-13 10:20:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/399393002/50001
6 years, 2 months ago (2014-10-13 10:41:25 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_swarming/builds/23410)
6 years, 2 months ago (2014-10-13 11:54:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/399393002/50001
6 years, 2 months ago (2014-10-14 00:24:43 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:50001)
6 years, 2 months ago (2014-10-14 01:38:41 UTC) #12
commit-bot: I haz the power
6 years, 2 months ago (2014-10-14 01:39:22 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/cd92ffb4655e9ccedaf19d3a787c874b847f89ac
Cr-Commit-Position: refs/heads/master@{#299417}

Powered by Google App Engine
This is Rietveld 408576698