Issue 399383007: hide public factory for intermediate class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 399383007: hide public factory for intermediate class (Closed)

Created:
6 years, 5 months ago by reed1

Modified:
6 years, 5 months ago

Reviewers:

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

hide public factory for intermediate class Use SK_DECLARE_UNFLATTENABLE_OBJECT if the subclass should not be directly instantiated. TBR= Committed: https://skia.googlesource.com/skia/+/3f8540346df30f2b681bcffd42edac15d609aec4

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -9 lines)			Patch
M	include/effects/Sk2DPathEffect.h	View	1 chunk	+2 lines, -7 lines	0 comments	Download
M	src/ports/SkGlobalInitialization_chromium.cpp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/ports/SkGlobalInitialization_default.cpp	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/399383007/1

6 years, 5 months ago (2014-07-21 14:20:40 UTC) #2

commit-bot: I haz the power

6 years, 5 months ago (2014-07-21 14:31:57 UTC) #3

Message was sent while issue was closed.

Change committed as 3f8540346df30f2b681bcffd42edac15d609aec4