Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 399383002: Check the actual size of canvas to update. (Closed)

Created:
6 years, 5 months ago by hirono
Modified:
6 years, 5 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Check the actual size of canvas to update. Previously the gallery checks the sequence number to find out whether the update for canvas size is needed or not. The sequence number is incremented when variables that affect canvas size are updated. But sometimes, the canvas size goes to be out of sync. BUG=245926 TEST=manually Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284052

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -16 lines) Patch
M ui/file_manager/gallery/js/image_editor/image_view.js View 1 2 3 chunks +4 lines, -16 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
hirono
PTAL the CL? Thank you!
6 years, 5 months ago (2014-07-18 08:19:44 UTC) #1
yoshiki
lgtm
6 years, 5 months ago (2014-07-18 08:20:56 UTC) #2
hirono
The CQ bit was checked by hirono@chromium.org
6 years, 5 months ago (2014-07-18 08:21:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/399383002/40001
6 years, 5 months ago (2014-07-18 08:21:48 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-18 10:45:59 UTC) #5
Message was sent while issue was closed.
Change committed as 284052

Powered by Google App Engine
This is Rietveld 408576698