extensions/renderer/module_system.cc - Issue 399363002: Add support for writing unit tests for Mojo-backed apps/extensions APIs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/module_system.cc

Issue 399363002: Add support for writing unit tests for Mojo-backed apps/extensions APIs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/renderer/module_system.cc

diff --git a/extensions/renderer/module_system.cc b/extensions/renderer/module_system.cc

index ab265fade68c92cba7f902d96365371fe22f1c42..1f337643476d06ad230eab1fb4949e61ec616a8f 100644

--- a/extensions/renderer/module_system.cc

+++ b/extensions/renderer/module_system.cc

@@ -230,9 +230,10 @@ v8::Local<v8::Value> ModuleSystem::RequireForJsInner(

v8::Local<v8::Value> ModuleSystem::CallModuleMethod(

const std::string& module_name,

const std::string& method_name) {

- v8::HandleScope handle_scope(GetIsolate());

+ v8::EscapableHandleScope handle_scope(GetIsolate());

v8::Handle<v8::Value> no_args;

- return CallModuleMethod(module_name, method_name, 0, &no_args);

+ return handle_scope.Escape(

+ CallModuleMethod(module_name, method_name, 0, &no_args));

}

v8::Local<v8::Value> ModuleSystem::CallModuleMethod(

« no previous file with comments | « extensions/renderer/dispatcher.cc ('k') | extensions/renderer/module_system_test.cc » ('j') | no next file with comments »