extensions/renderer/script_context.cc - Issue 399363002: Add support for writing unit tests for Mojo-backed apps/extensions APIs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/script_context.cc

Issue 399363002: Add support for writing unit tests for Mojo-backed apps/extensions APIs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/renderer/resources/test_custom_bindings.js ('K') | « extensions/renderer/resources/test_custom_bindings_delegate.js ('k') | extensions/test/DEPS » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/renderer/script_context.cc

diff --git a/extensions/renderer/script_context.cc b/extensions/renderer/script_context.cc

index 882837de7628cb18801e66b46f20f04a3c618a3d..159b3bc7fb6303aca6511255aedb8c0feb9b74f1 100644

--- a/extensions/renderer/script_context.cc

+++ b/extensions/renderer/script_context.cc

@@ -120,6 +120,8 @@ void ScriptContext::DispatchEvent(const char* event_name,

}

void ScriptContext::DispatchOnUnloadEvent() {

+ v8::HandleScope handle_scope(isolate());

+ v8::Context::Scope context_scope(v8_context());

module_system_->CallModuleMethod("unload_event", "dispatch");

}