Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 399353007: Revert of Change SPACEPARITY in the Windows serial api implementation to ODDPARITY. (Closed)

Created:
6 years, 5 months ago by gab
Modified:
6 years, 5 months ago
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Change SPACEPARITY in the Windows serial api implementation to ODDPARITY. (https://codereview.chromium.org/396023003/) Reason for revert: Very speculative revert for current XP bots failures (all 3 bots are failing with obscure errors and this is our last suspect in the list...). I'll reland if that's not it. Thanks for your understanding! Original issue's description: > Change SPACEPARITY in the Windows serial api implementation to ODDPARITY. > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284000 TBR=rockot@chromium.org,sammc@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284087

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M device/serial/serial_io_handler_win.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
gab
Created Revert of Change SPACEPARITY in the Windows serial api implementation to ODDPARITY.
6 years, 5 months ago (2014-07-18 14:13:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gab@chromium.org/399353007/1
6 years, 5 months ago (2014-07-18 14:13:33 UTC) #2
commit-bot: I haz the power
Change committed as 284087
6 years, 5 months ago (2014-07-18 14:14:34 UTC) #3
gab
6 years, 5 months ago (2014-07-18 17:06:57 UTC) #4
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/404823003/ by gab@chromium.org.

The reason for reverting is: Not the issue... re-landing..

Powered by Google App Engine
This is Rietveld 408576698