Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 399353006: Update test "LanguageOptionsWebUITest.reselectUILocale" (Closed)

Created:
6 years, 5 months ago by Alexey Kuzmin
Modified:
6 years, 4 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, dbeam+watch-options_chromium.org, nona+watch_chromium.org, yusukes+watch_chromium.org, yukishiino+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Update test "LanguageOptionsWebUITest.reselectUILocale" Current implementation assumes that current UI language is the first language on the list. It works now but might break in the future. To avoid that we should select current UI language on left pane before making any checks. R=dbeam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288439

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/ui/webui/options/language_options_browsertest.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Alexey Kuzmin
6 years, 5 months ago (2014-07-18 13:10:52 UTC) #1
Dan Beam
Hey Alexey, To land this code you need to sign this CLA first (yes, even ...
6 years, 5 months ago (2014-07-18 17:36:49 UTC) #2
Alexey Kuzmin
Hi Dan, According to External Contributor Checklist http://www.chromium.org/developers/contributing-code/external-contributor-checklist : > If there's a corporate CLA ...
6 years, 5 months ago (2014-07-19 15:11:18 UTC) #3
Dan Beam
On 2014/07/19 15:11:18, Alexey Kuzmin wrote: > Hi Dan, > > According to External Contributor ...
6 years, 5 months ago (2014-07-22 21:53:29 UTC) #4
Ilya Golubtsov
Hi, Dan. More then a year ago we sent CLA which allows to contribute to ...
6 years, 5 months ago (2014-07-25 10:22:40 UTC) #5
Dan Beam
lgtm
6 years, 4 months ago (2014-08-08 18:04:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jj-spoon@yandex-team.ru/399353006/1
6 years, 4 months ago (2014-08-08 18:06:39 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-08-08 21:32:29 UTC) #8
Message was sent while issue was closed.
Change committed as 288439

Powered by Google App Engine
This is Rietveld 408576698