Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 399333002: add blink_disable_partition_allocator for memory profiler. (Closed)

Created:
6 years, 5 months ago by JungJik
Modified:
6 years, 5 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

add blink_disable_partition_allocator for memory profiler. PartitionAlloc manages memory chunks which are pre-allocated and re-assigned to the caller which requests memory allocation. so the top point of stack unwinding is always inside PartitionAlloc in blink. this can make profiler know wrong allocation point. if this gyp flag is set, blink uses base allocator. so that it can show exact callstack where actual allocation is requested. Bug=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178419

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M Source/config.gyp View 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
JungJik
I made new same patch due to the wrong base url. I am sorry about ...
6 years, 5 months ago (2014-07-18 02:19:38 UTC) #1
abarth-chromium
lgtm
6 years, 5 months ago (2014-07-18 03:07:57 UTC) #2
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 5 months ago (2014-07-18 03:07:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jungjik.lee@samsung.com/399333002/1
6 years, 5 months ago (2014-07-18 03:08:23 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_blink_compile_dbg on tryserver.blink ...
6 years, 5 months ago (2014-07-18 04:13:06 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-18 04:25:20 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_blink_compile_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/android_blink_compile_dbg/builds/6486)
6 years, 5 months ago (2014-07-18 04:25:21 UTC) #7
JungJik
The CQ bit was checked by jungjik.lee@samsung.com
6 years, 5 months ago (2014-07-18 06:47:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jungjik.lee@samsung.com/399333002/1
6 years, 5 months ago (2014-07-18 06:47:53 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-18 06:55:21 UTC) #10
Message was sent while issue was closed.
Change committed as 178419

Powered by Google App Engine
This is Rietveld 408576698