Mark SyncTest#testDisableAndEnableSync as flaky.

Mark SyncTest#testDisableAndEnableSync as flaky.

BUG=311091
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=230738

[Peter Beverloo, 2013-10-24 11:12:35]

+bulach for testing magic

https://codereview.chromium.org/39933002/diff/1/chrome/android/javatests/src/...
File chrome/android/javatests/src/org/chromium/chrome/browser/sync/SyncTest.java
(right):

https://codereview.chromium.org/39933002/diff/1/chrome/android/javatests/src/...
chrome/android/javatests/src/org/chromium/chrome/browser/sync/SyncTest.java:143:
@FlakyTest
I *think* we can only have one @*Test annotation, but commenting out
@HostDrivenTest would change the test runner this would be run with, which is
not the intended affect.

Marcus, is this the right way of annotating a host driven test as being flaky?

[bulach, 2013-10-24 13:30:29]

lgtm

I think so, tests can have multiple annotations.

as for the bug report: mind including the logcat for that test? go to the
"logcat_dump", find where it started this test, then paste the snippet in the
bug... most of the time it provides handy information for debugging.. thanks!

[commit-bot: I haz the power, 2013-10-24 13:36:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mvanouwerkerk@chromium.org/39933002/1

[Michael van Ouwerkerk, 2013-10-24 13:37:59]

On 2013/10/24 13:30:29, bulach wrote:
> lgtm
> 
> I think so, tests can have multiple annotations.
> 
> as for the bug report: mind including the logcat for that test? go to the
> "logcat_dump", find where it started this test, then paste the snippet in the
> bug... most of the time it provides handy information for debugging.. thanks!

Not sure if there is a logcat_dump for it... couldn't find it, sorry!

[commit-bot: I haz the power, 2013-10-24 16:38:37]

Change committed as 230738

[nyquist, 2013-10-24 17:20:06]

On 2013/10/24 16:38:37, I haz the power (commit-bot) wrote:
> Change committed as 230738

This CL is wrong. It is a host driven test, so the annotation should live in the
python part of the test. See chrome/android/host_driven_tests/SyncTest.py