Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 399313008: Remove HID devices not found during enumeration on Windows. (Closed)

Created:
6 years, 5 months ago by Reilly Grant (use Gerrit)
Modified:
6 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove HID devices not found during enumeration on Windows. Windows doesn't give us fine grained notifications for device add and remove so we must do a complete enumeration every time. This patch figures out which devices are no longer present in the enumeration and calls HidService::RemoveDevice. BUG=395272 R=rockot@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284321

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add a protected const accessor instead of making devices_ protected. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -59 lines) Patch
M device/hid/hid_service.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M device/hid/hid_service.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M device/hid/hid_service_win.cc View 1 1 chunk +77 lines, -59 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Reilly Grant (use Gerrit)
6 years, 5 months ago (2014-07-19 00:11:31 UTC) #1
Ken Rockot(use gerrit already)
lgtm https://codereview.chromium.org/399313008/diff/1/device/hid/hid_service.h File device/hid/hid_service.h (left): https://codereview.chromium.org/399313008/diff/1/device/hid/hid_service.h#oldcode57 device/hid/hid_service.h:57: DeviceMap devices_; Can you just leave this private ...
6 years, 5 months ago (2014-07-19 00:13:51 UTC) #2
Reilly Grant (use Gerrit)
6 years, 5 months ago (2014-07-19 00:34:21 UTC) #3
Reilly Grant (use Gerrit)
The CQ bit was checked by reillyg@chromium.org
6 years, 5 months ago (2014-07-19 01:14:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/reillyg@chromium.org/399313008/20001
6 years, 5 months ago (2014-07-19 01:16:09 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-19 05:11:18 UTC) #6
Message was sent while issue was closed.
Change committed as 284321

Powered by Google App Engine
This is Rietveld 408576698