Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1328)

Unified Diff: mojo/public/cpp/bindings/lib/validation_errors.cc

Issue 399313007: Mojo: Convert assert()s under mojo/public/cpp/bindings/... to MOJO_DCHECK()s. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/public/cpp/bindings/lib/validation_errors.cc
diff --git a/mojo/public/cpp/bindings/lib/validation_errors.cc b/mojo/public/cpp/bindings/lib/validation_errors.cc
index d830f02fc3c4a57ccbea7cf1221114a2350f6fd1..c1bd9ae76421ca158c3397781b1c9c6599b6b508 100644
--- a/mojo/public/cpp/bindings/lib/validation_errors.cc
+++ b/mojo/public/cpp/bindings/lib/validation_errors.cc
@@ -4,8 +4,6 @@
#include "mojo/public/cpp/bindings/lib/validation_errors.h"
-#include <assert.h>
-
#include "mojo/public/cpp/environment/logging.h"
namespace mojo {
@@ -50,12 +48,12 @@ void ReportValidationError(ValidationError error) {
ValidationErrorObserverForTesting::ValidationErrorObserverForTesting()
: last_error_(VALIDATION_ERROR_NONE) {
- assert(!g_validation_error_observer);
+ MOJO_DCHECK(!g_validation_error_observer);
g_validation_error_observer = this;
}
ValidationErrorObserverForTesting::~ValidationErrorObserverForTesting() {
- assert(g_validation_error_observer == this);
+ MOJO_DCHECK(g_validation_error_observer == this);
g_validation_error_observer = NULL;
}

Powered by Google App Engine
This is Rietveld 408576698