Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1213)

Unified Diff: mojo/public/cpp/bindings/lib/interface_impl_internal.h

Issue 399313007: Mojo: Convert assert()s under mojo/public/cpp/bindings/... to MOJO_DCHECK()s. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/public/cpp/bindings/lib/interface_impl_internal.h
diff --git a/mojo/public/cpp/bindings/lib/interface_impl_internal.h b/mojo/public/cpp/bindings/lib/interface_impl_internal.h
index 1c912661fd96a95d41661add0ad664f05ce063b3..d94d12de0c90b01dc98de781fada535c55f5cbb0 100644
--- a/mojo/public/cpp/bindings/lib/interface_impl_internal.h
+++ b/mojo/public/cpp/bindings/lib/interface_impl_internal.h
@@ -10,6 +10,7 @@
#include "mojo/public/cpp/bindings/lib/filter_chain.h"
#include "mojo/public/cpp/bindings/lib/message_header_validator.h"
#include "mojo/public/cpp/environment/environment.h"
+#include "mojo/public/cpp/environment/logging.h"
#include "mojo/public/cpp/system/macros.h"
namespace mojo {
@@ -31,7 +32,7 @@ class InterfaceImplState : public ErrorHandler {
explicit InterfaceImplState(InterfaceImplBase<Interface>* instance)
: router_(NULL),
proxy_(NULL) {
- assert(instance);
+ MOJO_DCHECK(instance);
stub_.set_sink(instance);
}
@@ -53,7 +54,7 @@ class InterfaceImplState : public ErrorHandler {
void Bind(ScopedMessagePipeHandle handle,
const MojoAsyncWaiter* waiter) {
- assert(!router_);
+ MOJO_DCHECK(!router_);
FilterChain filters;
filters.Append<MessageHeaderValidator>();
@@ -70,7 +71,7 @@ class InterfaceImplState : public ErrorHandler {
}
bool WaitForIncomingMethodCall() {
- assert(router_);
+ MOJO_DCHECK(router_);
return router_->WaitForIncomingMessage();
}

Powered by Google App Engine
This is Rietveld 408576698