Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 399313005: X87: StubCallInterfaceDescriptor takes a context register. (Closed)

Created:
6 years, 5 months ago by chunyang.dai
Modified:
6 years, 5 months ago
Reviewers:
Weiliang, mvstanton
CC:
v8-dev, danno
Base URL:
https://chromium.googlesource.com/external/v8.git@bleeding_edge
Project:
v8
Visibility:
Public.

Description

X87: StubCallInterfaceDescriptor takes a context register. port r22448 original commit message: StubCallInterfaceDescriptor and CallInterfaceDescriptor are unified under a base class InterfaceDescriptor. Handling of the context register had to be massaged to effect the unification. This will make it easier to call hydrogen code stubs directly from crankshaft. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -38 lines) Patch
M src/x87/code-stubs-x87.cc View 18 chunks +40 lines, -32 lines 0 comments Download
M src/x87/lithium-x87.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/x87/lithium-x87.cc View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
chunyang.dai
weiliang please review this porting patch. thanks.
6 years, 5 months ago (2014-07-18 02:45:52 UTC) #1
Weiliang
lgtm
6 years, 5 months ago (2014-07-18 03:15:10 UTC) #2
Weiliang
6 years, 5 months ago (2014-07-18 03:18:43 UTC) #3
Committed as r22459

Powered by Google App Engine
This is Rietveld 408576698