Source/modules/wake_lock/WakeLock.idl - Issue 399313003: Initial implementation of API WakeLock.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/modules/wake_lock/WakeLock.idl

Issue 399313003: Initial implementation of API WakeLock. Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Implementation of WakeLock API on JavaScript side Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« Source/modules/wake_lock/WakeLock.h ('K') | « Source/modules/wake_lock/WakeLock.cpp ('k') | Source/modules/wake_lock/WakeLockController.h » ('j') | Source/modules/wake_lock/WakeLockController.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2014 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 enum WakeLockType {

	6 "screen",

	7 "system"
	mlamouri (slow - plz ping) 2014/08/18 12:15:53 Do you intend to implement "system"? Should we sti Do you intend to implement "system"? Should we stick with "screen" for the moment? We should consider how to behave if we support "screen" but not "system": should we reject "system" as an unknown keyword or reject it as known but unsupported? redchenko 2014/08/19 16:42:20 Yes we do, as Chromium's PowerSaveBlocker already Show quoted text On 2014/08/18 12:15:53, Mounir Lamouri wrote: > Do you intend to implement "system"? Should we stick with "screen" for the > moment? We should consider how to behave if we support "screen" but not > "system": should we reject "system" as an unknown keyword or reject it as known > but unsupported? Yes we do, as Chromium's PowerSaveBlocker already has the code for that.
	8 };

	9

	10 [

	11 RuntimeEnabled=WakeLock,

	12 WillBeGarbageCollected,

	13 NoInterfaceObject,
	mlamouri (slow - plz ping) 2014/08/18 12:15:53 Why is that NoInterfaceObject? It's unlikely what Why is that NoInterfaceObject? It's unlikely what we want. redchenko 2014/08/19 16:42:20 Done. Show quoted text On 2014/08/18 12:15:53, Mounir Lamouri wrote: > Why is that NoInterfaceObject? It's unlikely what we want. Done.
	14 ] interface WakeLock {

	15 [CallWith=ScriptState] Promise request(WakeLockType type);

	16 [CallWith=ScriptState] Promise release(WakeLockType type);

	17 boolean isHeld(WakeLockType type);
	mlamouri (slow - plz ping) 2014/08/18 12:15:52 Should you add an event handler for when the lock Should you add an event handler for when the lock changes? redchenko 2014/08/19 16:42:20 Right, I'm planning it in the next CLs. Also there Show quoted text On 2014/08/18 12:15:52, Mounir Lamouri wrote: > Should you add an event handler for when the lock changes? Right, I'm planning it in the next CLs. Also there are questions about event types we need.
	18 };

OLD	NEW