Eliminate use of sim unlock UI notifications

chrome/browser/resources/options/chromeos/internet_detail.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // NOTE(stevenjb): This code is in the process of being converted to be
 // compatible with the networkingPrivate extension API:
 // * The network property dictionaries are being converted to use ONC values.
 // * chrome.send calls will be replaced with an API object that simulates the
 //   networkingPrivate API. See network_config.js.
 // See crbug.com/279351 for more info.
@@ skipping 417 matching lines @@
       $('ipconfig-section').hidden = !this.connected && this.deviceConnected;
       $('ipconfig-dns-section').hidden =
         !this.connected && this.deviceConnected;
 
       // Network type related.
       updateHidden('#details-internet-page .cellular-details', !this.cellular);
       updateHidden('#details-internet-page .wifi-details', !this.wireless);
       updateHidden('#details-internet-page .wimax-details', !this.wimax);
       updateHidden('#details-internet-page .vpn-details', !this.vpn);
       updateHidden('#details-internet-page .proxy-details', !this.showProxy);
+
+      // Cellular
+
       // Conditionally call updateHidden on .gsm-only, so that we don't unhide
       // a previously hidden element.
       if (this.gsm)
         updateHidden('#details-internet-page .cdma-only', true);
       else
         updateHidden('#details-internet-page .gsm-only', true);
-      /* Network information merged into the Wifi tab for wireless networks
-         unless the option is set for enabling a static IP configuration. */
+
+      // Wifi
+
+      // Network information merged into the Wifi tab for wireless networks
+      // unless the option is set for enabling a static IP configuration.
       updateHidden('#details-internet-page .network-details',
                    (this.wireless && !this.showStaticIPConfig) || this.vpn);
       updateHidden('#details-internet-page .wifi-network-setting',
                    this.showStaticIPConfig);
 
-      // Wifi - Password and shared.
+      // Password and shared.
       updateHidden('#details-internet-page #password-details',
                    !this.wireless || !this.hasSecurity);
       updateHidden('#details-internet-page #wifi-shared-network',
           !this.shared);
       updateHidden('#details-internet-page #prefer-network',
                    !this.showPreferred);
 
       // WiMAX.
       updateHidden('#details-internet-page #wimax-shared-network',
         !this.shared);
@@ skipping 234 matching lines @@
           $(proxyHost).value = hostValue[0];
           $(proxyPort).value = hostValue[1];
         }
       }
   };
 
   DetailsInternetPage.updateCarrier = function() {
     DetailsInternetPage.showCarrierChangeSpinner(false);
   };
 
-  DetailsInternetPage.updateSecurityTab = function(requirePin) {
-    $('sim-card-lock-enabled').checked = requirePin;
-    $('change-pin').hidden = !requirePin;
-  };
-
   DetailsInternetPage.loginFromDetails = function() {
     var data = $('connection-state').data;
     var servicePath = data.servicePath;
     chrome.send('networkCommand', [data.Type, servicePath, 'connect']);
     OptionsPage.closeOverlay();
   };
 
   DetailsInternetPage.disconnectNetwork = function() {
     var data = $('connection-state').data;
     var servicePath = data.servicePath;
@@ skipping 153 matching lines @@
       $('wimax-connection-state').textContent = connectionStateString;
     } else if (data.Type == 'Cellular') {
       $('activation-state').textContent = data.activationState;
 
       $('buyplan-details').hidden = !data.showBuyButton;
       $('view-account-details').hidden = !data.showViewAccountButton;
 
       $('activate-details').hidden = !data.showActivateButton;
       if (data.showActivateButton)
         $('details-internet-login').hidden = true;
+
+      if (detailsPage.gsm) {
+        // TODO(stevenjb): Use managed properties for policy controlled values.
+        var lockEnabled = data.simCardLockEnabled.value;
+        $('sim-card-lock-enabled').checked = lockEnabled;
+        $('change-pin').hidden = !lockEnabled;
+      }

[stevenjb, 2014/07/18 00:29:40]

All of the logic in updateConnectionData is currently duplicated, we will fix
that in another CL, but for now this was easiest.

     }
 
     $('connection-state').data = data;
   };
 
   DetailsInternetPage.showDetailedInfo = function(data) {
     var detailsPage = DetailsInternetPage.getInstance();
 
     // Populate header
     $('network-details-title').textContent = getNetworkName(data);
@@ skipping 322 matching lines @@
           var option = document.createElement('option');
           option.textContent = data.apn.apn;
           option.value = -1;
           apnSelector.add(option, otherOption);
           data.selectedApn = apnSelector.length - 2;
           data.userApnIndex = data.selectedApn;
         }
         apnSelector.selectedIndex = data.selectedApn;
         updateHidden('.apn-list-view', false);
         updateHidden('.apn-details-view', true);
-        DetailsInternetPage.updateSecurityTab(data.simCardLockEnabled.value);
+        // TODO(stevenjb): Used managed properties for policy controlled value.
+        var lockEnabled = data.simCardLockEnabled.value;
+        $('sim-card-lock-enabled').checked = lockEnabled;
+        $('change-pin').hidden = !lockEnabled;
       }
       $('auto-connect-network-cellular').checked = data.autoConnect.value;
       $('auto-connect-network-cellular').disabled = false;
 
       $('buyplan-details').hidden = !data.showBuyButton;
       $('view-account-details').hidden = !data.showViewAccountButton;
       $('activate-details').hidden = !data.showActivateButton;
       if (data.showActivateButton) {
         $('details-internet-login').hidden = true;
       }
@@ skipping 56 matching lines @@
 
     // Don't show page name in address bar and in history to prevent people
     // navigate here by hand and solve issue with page session restore.
     OptionsPage.showPageByName('detailsInternetPage', false);
   };
 
   return {
     DetailsInternetPage: DetailsInternetPage
   };
 });