Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Unified Diff: tools/telemetry/telemetry/value/failure_unittest.py

Issue 399263003: Add FailureValue and wire it through PageTestResults. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update another usage of self.failures, fix unit tests. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/value/failure.py ('k') | tools/telemetry/telemetry/value/merge_values.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/value/failure_unittest.py
diff --git a/tools/telemetry/telemetry/value/failure_unittest.py b/tools/telemetry/telemetry/value/failure_unittest.py
new file mode 100644
index 0000000000000000000000000000000000000000..799e047f691517c7f944ea34f8067fd8cf65b41f
--- /dev/null
+++ b/tools/telemetry/telemetry/value/failure_unittest.py
@@ -0,0 +1,44 @@
+# Copyright 2014 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+import os
+import sys
+import unittest
+
+from telemetry import value
+from telemetry.page import page_set
+from telemetry.value import failure
+
+class TestBase(unittest.TestCase):
+ def setUp(self):
+ self.page_set = page_set.PageSet(file_path=os.path.dirname(__file__))
+ self.page_set.AddPageWithDefaultRunNavigate("http://www.bar.com/")
+
+ @property
+ def pages(self):
+ return self.page_set.pages
+
+class ValueTest(TestBase):
+ def testName(self):
+ v0 = failure.FailureValue.FromMessage(self.pages[0], 'Failure')
+ self.assertEqual('Exception', v0.name)
+ try:
+ raise NotImplementedError()
+ except Exception:
+ v1 = failure.FailureValue(self.pages[0], sys.exc_info())
+ self.assertEqual('NotImplementedError', v1.name)
+
+ def testBuildbotAndRepresentativeValue(self):
+ v = failure.FailureValue.FromMessage(self.pages[0], 'Failure')
+ self.assertIsNone(v.GetBuildbotValue())
+ self.assertIsNone(v.GetBuildbotDataType(
+ value.COMPUTED_PER_PAGE_SUMMARY_OUTPUT_CONTEXT))
+ self.assertIsNone(v.GetBuildbotMeasurementAndTraceNameForPerPageResult())
+ self.assertIsNone(v.GetRepresentativeNumber())
+ self.assertIsNone(v.GetRepresentativeString())
+
+ def testAsDict(self):
+ v = failure.FailureValue.FromMessage(self.pages[0], 'Failure')
+ d = v.AsDictWithoutBaseClassEntries()
+ self.assertTrue(d['value'].find('Exception: Failure') > -1)
« no previous file with comments | « tools/telemetry/telemetry/value/failure.py ('k') | tools/telemetry/telemetry/value/merge_values.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698