Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Unified Diff: tools/telemetry/telemetry/results/page_test_results_unittest.py

Issue 399263003: Add FailureValue and wire it through PageTestResults. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update another usage of self.failures, fix unit tests. Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/results/page_test_results.py ('k') | tools/telemetry/telemetry/value/failure.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/results/page_test_results_unittest.py
diff --git a/tools/telemetry/telemetry/results/page_test_results_unittest.py b/tools/telemetry/telemetry/results/page_test_results_unittest.py
index 42dde5965e731468cf8f32fa098a73af0dca8a61..ba5690bd8f6ff6aa3b0464d1b70314f65e2b46cd 100644
--- a/tools/telemetry/telemetry/results/page_test_results_unittest.py
+++ b/tools/telemetry/telemetry/results/page_test_results_unittest.py
@@ -6,6 +6,7 @@ from telemetry.results import base_test_results_unittest
from telemetry.page import page_set
from telemetry.results import page_test_results
+from telemetry.value import failure
class NonPrintingPageTestResults(
page_test_results.PageTestResults):
@@ -28,8 +29,8 @@ class PageTestResultsTest(base_test_results_unittest.BaseTestResultsUnittest):
def test_failures(self):
results = NonPrintingPageTestResults()
- results.AddFailure(self.pages[0], self.CreateException())
+ results.AddValue(
+ failure.FailureValue(self.pages[0], self.CreateException()))
results.AddSuccess(self.pages[1])
- self.assertEquals(results.pages_that_had_failures,
- set([self.pages[0]]))
+ self.assertEquals(results.pages_that_had_failures, [self.pages[0]])
self.assertEquals(results.successes, [self.pages[1]])
« no previous file with comments | « tools/telemetry/telemetry/results/page_test_results.py ('k') | tools/telemetry/telemetry/value/failure.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698