tools/telemetry/telemetry/page/profile_generator.py - Issue 399263003: Add FailureValue and wire it through PageTestResults.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/profile_generator.py

Issue 399263003: Add FailureValue and wire it through PageTestResults. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update another usage of self.failures, fix unit tests. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/page/profile_generator.py

diff --git a/tools/telemetry/telemetry/page/profile_generator.py b/tools/telemetry/telemetry/page/profile_generator.py

index 979ece9bd2bf72b731aaf896cd2471604a78496e..daa1026bc8f4009c0bed769dad6ee2e0f4764eda 100644

--- a/tools/telemetry/telemetry/page/profile_generator.py

+++ b/tools/telemetry/telemetry/page/profile_generator.py

@@ -49,7 +49,7 @@ def GenerateProfiles(profile_creator_class, profile_creator_name, options):

if results.failures:

logging.warning('Some pages failed.')

logging.warning('Failed pages:\n%s',

- '\n'.join(zip(*results.failures)[0]))

+ '\n'.join(results.pages_that_had_failures))

return 1

# Everything is a-ok, move results to final destination.

« no previous file with comments | « tools/telemetry/telemetry/page/page_runner.py ('k') | tools/telemetry/telemetry/page/record_wpr.py » ('j') | no next file with comments »