Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 399263002: telemetry: Avoid breakage if user SSH config enables ControlMaster (Closed)

Created:
6 years, 5 months ago by joshtriplett
Modified:
6 years, 5 months ago
Reviewers:
dtu, tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

telemetry: Avoid breakage if user SSH config enables ControlMaster telemetry's cros_interface cannot handle a persistent master connection; it will hang until the master connection exits. Explicitly disable ControlMaster on the command line, to override any user configuration enabling it. Observed when attempting to use run_gpu_test.py on Chrome OS with a ~/.ssh/config in the chroot that enabled ControlMaster and ControlPersist; each invocation of ssh by run_gpu_test.py hung until the timeout specified in ControlPersist expired. With this change, run_gpu_test.py completes successfully despite that user configuration. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284001

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M tools/telemetry/telemetry/core/backends/chrome/cros_interface.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
joshtriplett
6 years, 5 months ago (2014-07-17 21:55:16 UTC) #1
tonyg
lgtm
6 years, 5 months ago (2014-07-17 21:57:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/josh@joshtriplett.org/399263002/1
6 years, 5 months ago (2014-07-17 21:59:09 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-18 02:18:06 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-18 03:48:55 UTC) #5
Message was sent while issue was closed.
Change committed as 284001

Powered by Google App Engine
This is Rietveld 408576698