Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Unified Diff: tests/gclient_test.py

Issue 399223002: Convert recursedeps test syntax to list literal. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/gclient_test.py
diff --git a/tests/gclient_test.py b/tests/gclient_test.py
index e6185956fe9dcd28d776967b90a4838d0080ac53..c246efc4978c84395a241978593bb92a7564f9f5 100755
--- a/tests/gclient_test.py
+++ b/tests/gclient_test.py
@@ -664,7 +664,7 @@ class GclientTest(trial_dir.TestCase):
"""Verifies gclient respects the |recursedeps| var syntax.
This is what we mean to check here:
- - |recursedeps| = {...} on 2 levels means we pull exactly 3 deps
+ - |recursedeps| = [...] on 2 levels means we pull exactly 3 deps
(up to /fizz, but not /fuzz)
- pulling foo/bar with no recursion (in .gclient) is overriden by
a later pull of foo/bar with recursion (in the dep tree)
@@ -683,13 +683,13 @@ class GclientTest(trial_dir.TestCase):
'deps = {\n'
' "bar": "/bar",\n'
'}\n'
- 'recursedeps = {"bar"}')
+ 'recursedeps = ["bar"]')
write(
os.path.join('bar', 'DEPS'),
'deps = {\n'
' "baz": "/baz",\n'
'}\n'
- 'recursedeps = {"baz"}')
+ 'recursedeps = ["baz"]')
write(
os.path.join('baz', 'DEPS'),
'deps = {\n'
@@ -734,7 +734,7 @@ class GclientTest(trial_dir.TestCase):
'deps = {\n'
' "bar": "/bar",\n'
'}\n'
- 'recursedeps = {"bar"}')
+ 'recursedeps = ["bar"]')
write(
os.path.join('bar', 'DEPS'),
'deps = {\n'
@@ -806,7 +806,7 @@ class GclientTest(trial_dir.TestCase):
' "bar": "/bar",\n'
'}\n'
'recursion = 3\n'
- 'recursedeps = {"bar"}')
+ 'recursedeps = ["bar"]')
write(
os.path.join('bar', 'DEPS'),
'deps = {\n'
@@ -822,7 +822,7 @@ class GclientTest(trial_dir.TestCase):
'deps = {\n'
' "fuzz": "/fuzz",\n'
'}\n'
- 'recursedeps = {"fuzz"}')
+ 'recursedeps = ["fuzz"]')
write(
os.path.join('fuzz', 'DEPS'),
'deps = {\n'
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698