Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Unified Diff: content/browser/renderer_host/render_widget_resize_helper.h

Issue 399213003: Fix crash in Mac ASAN RenderWidgetResizeHelper (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@move_to_cpp
Patch Set: Fix name Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/renderer_host/render_widget_resize_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/render_widget_resize_helper.h
diff --git a/content/browser/renderer_host/render_widget_resize_helper.h b/content/browser/renderer_host/render_widget_resize_helper.h
index d9ccf18136d0af9e7e464e643869341d93613145..b359a75ac77b1080eb902b8d165e6df43314c192 100644
--- a/content/browser/renderer_host/render_widget_resize_helper.h
+++ b/content/browser/renderer_host/render_widget_resize_helper.h
@@ -82,12 +82,13 @@ class RenderWidgetResizeHelper {
void PostEnqueuedTask(EnqueuedTask* proxy);
// Called on the UI to remove the task from the queue when it is run.
- void WillRunEnqueuedTask(EnqueuedTask* proxy);
+ void RemoveEnqueuedTaskFromQueue(EnqueuedTask* proxy);
- // A queue of live messages. Must hold |task_queue_lock_| to access.
- // The EnqueuedTask objects are removed from the front of the queue when
- // they are run (either by TaskRunner they were posted to or by a call to
- // WaitForSingleTaskToRun pulling them off of the queue).
+ // A queue of live messages. Must hold |task_queue_lock_| to access. Tasks
+ // are added only on the IO thread and removed only on the UI thread. The
+ // EnqueuedTask objects are removed from the front of the queue when they are
+ // run (by TaskRunner they were posted to, by a call to WaitForSingleTaskToRun
+ // pulling them off of the queue, or by TaskRunner when it is destroyed).
typedef std::deque<EnqueuedTask*> EnqueuedTaskQueue;
EnqueuedTaskQueue task_queue_;
base::Lock task_queue_lock_;
« no previous file with comments | « no previous file | content/browser/renderer_host/render_widget_resize_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698