Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issue 399193002: DevTools: do not trigger autocomplete on deletion (Closed)

Created:
6 years, 5 months ago by lushnikov
Modified:
6 years, 5 months ago
Reviewers:
vsevik, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: do not trigger autocomplete on deletion Currently, deletion of a single letter in the end of the word will trigger autocompletion (if any). As this is considered disturbing, this patch switches off autocompletion summoning for this case. R=vsevik, pfeldman Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178427

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
lushnikov
ptal
6 years, 5 months ago (2014-07-17 18:22:56 UTC) #1
vsevik
lgtm
6 years, 5 months ago (2014-07-18 06:02:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/399193002/1
6 years, 5 months ago (2014-07-18 06:02:49 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-07-18 07:06:28 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-18 07:39:03 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/17651)
6 years, 5 months ago (2014-07-18 07:39:04 UTC) #6
lushnikov
The CQ bit was checked by lushnikov@chromium.org
6 years, 5 months ago (2014-07-18 08:43:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/399193002/1
6 years, 5 months ago (2014-07-18 08:44:24 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-07-18 09:30:41 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-18 10:12:46 UTC) #10
Message was sent while issue was closed.
Change committed as 178427

Powered by Google App Engine
This is Rietveld 408576698